This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 62f9a3a6f [MINOR] fix(CI): Improve dashboard across the CI (#1526)
62f9a3a6f is described below

commit 62f9a3a6f3bb97ca661ff9c42f55516596202757
Author: Enrico Minack <[email protected]>
AuthorDate: Thu Feb 15 04:59:43 2024 +0100

    [MINOR] fix(CI): Improve dashboard across the CI (#1526)
    
    ### What changes were proposed in this pull request?
    Improves how dashboard is build and tested in the Github CI.
    
    ### Why are the changes needed?
    Changes in #1498 were not considering the actual state of dashboard within 
the Maven project.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    CI.
---
 .github/workflows/parallel.yml   |  5 +++--
 .github/workflows/sequential.yml | 23 +++++++++++++----------
 .github/workflows/single.yml     |  4 ++--
 3 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/parallel.yml b/.github/workflows/parallel.yml
index 569c27ae0..5468e57c1 100644
--- a/.github/workflows/parallel.yml
+++ b/.github/workflows/parallel.yml
@@ -64,6 +64,7 @@ jobs:
           - mr-hadoop3.2
           - tez
           - tez-hadoop3.2
+          - dashboard
       fail-fast: false
     name: -P${{ matrix.profile }}
     steps:
@@ -84,11 +85,11 @@ jobs:
         restore-keys: |
           mvn-${{ inputs.java-version }}-package-${{ matrix.profile }}-
           mvn-${{ inputs.java-version }}-package-
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -P${{ matrix.profile }} 
-Pdashboard`
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -P${{ matrix.profile }}`
       run: |
         PROFILES="${{ matrix.profile }}"
         PROFILES=${PROFILES/-/,}
-        ./mvnw -B -fae ${{ inputs.maven-args }} -P${PROFILES} -Pdashboard | 
tee /tmp/maven.log
+        ./mvnw -B -fae ${{ inputs.maven-args }} -P${PROFILES} | tee 
/tmp/maven.log
       shell: bash
     - name: Summary of failures
       if: failure() && inputs.summary != ''
diff --git a/.github/workflows/sequential.yml b/.github/workflows/sequential.yml
index a661fa1b0..409ab3ad1 100644
--- a/.github/workflows/sequential.yml
+++ b/.github/workflows/sequential.yml
@@ -68,20 +68,23 @@ jobs:
         key: mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-${{ 
hashFiles('**/pom.xml') }}
         restore-keys: |
           mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pspark3 -Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pspark3 -Pdashboard | tee 
-a /tmp/maven.log;
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pspark3`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pspark3 | tee -a 
/tmp/maven.log;
       shell: bash
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pspark2 -Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pspark2 -Pdashboard | tee 
-a /tmp/maven.log;
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pspark2`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pspark2 | tee -a 
/tmp/maven.log;
       shell: bash
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pmr,hadoop2.8 
-Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pmr,hadoop2.8 -Pdashboard 
| tee -a /tmp/maven.log;
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pmr,hadoop2.8`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pmr,hadoop2.8 | tee -a 
/tmp/maven.log;
       shell: bash
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pmr,hadoop3.2 
-Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pmr,hadoop3.2 -Pdashboard 
| tee -a /tmp/maven.log;
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pmr,hadoop3.2`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pmr,hadoop3.2 | tee -a 
/tmp/maven.log;
       shell: bash
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Ptez -Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Ptez -Pdashboard | tee -a 
/tmp/maven.log;
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Ptez`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Ptez | tee -a 
/tmp/maven.log;
+      shell: bash
+    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pdashboard`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pdashboard | tee -a 
/tmp/maven.log;
       shell: bash
     - name: Summary of failures
       if: ${{ failure() && inputs.summary != '' }}
diff --git a/.github/workflows/single.yml b/.github/workflows/single.yml
index 241c83689..f611094d0 100644
--- a/.github/workflows/single.yml
+++ b/.github/workflows/single.yml
@@ -77,8 +77,8 @@ jobs:
       uses: actions/setup-go@v3
       with:
         go-version: ${{ inputs.go-version }}
-    - name: Execute `./mvnw ${{ inputs.maven-args }} -Pdashboard`
-      run: ./mvnw -B -fae ${{ inputs.maven-args }} -Pdashboard | tee 
/tmp/maven.log
+    - name: Execute `./mvnw ${{ inputs.maven-args }}`
+      run: ./mvnw -B -fae ${{ inputs.maven-args }} | tee /tmp/maven.log
       shell: bash
     - name: Summary of failures
       if: ${{ failure() && inputs.summary != '' }}

Reply via email to