This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new ff555c553 [MINOR] Update dashboard pom.xml to take arguments for node
and npm download locations (#1530)
ff555c553 is described below
commit ff555c5535f950ae5a15ffc781c948af884e67eb
Author: Connor Wilkes <[email protected]>
AuthorDate: Tue Feb 20 08:26:54 2024 +0000
[MINOR] Update dashboard pom.xml to take arguments for node and npm
download locations (#1530)
### What changes were proposed in this pull request?
When building the dashboard from within an environment without direct
internet access you may need to setup a mirror for node and npm download.
This change adds these as args to build like so:
`-PnodeRepositoryUrl=https://nodeDownloadLocation
-PnpmRepositoryUrl=https://npmDownloadLocation`
The defaults are added as the default args as per
https://github.com/eirslett/frontend-maven-plugin
### Why are the changes needed?
Enables build in more environments
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested build
Co-authored-by: Enrico Minack <[email protected]>
---
dashboard/pom.xml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/dashboard/pom.xml b/dashboard/pom.xml
index a8870a392..6fffae0c8 100644
--- a/dashboard/pom.xml
+++ b/dashboard/pom.xml
@@ -26,6 +26,11 @@
<artifactId>dashboard</artifactId>
<name>Apache Uniffle Dashboard</name>
+
+ <properties>
+ <nodeRepositoryUrl>https://nodejs.org/dist/</nodeRepositoryUrl>
+ <npmRepositoryUrl>https://registry.npmjs.org/npm/-/</npmRepositoryUrl>
+ </properties>
<dependencies>
<dependency>
@@ -50,7 +55,8 @@
<configuration>
<nodeVersion>v14.21.3</nodeVersion>
<npmVersion>6.14.18</npmVersion>
-
<nodeDownloadRoot>https://nodejs.org/dist/</nodeDownloadRoot>
+
<nodeDownloadRoot>${nodeRepositoryUrl}</nodeDownloadRoot>
+
<npmDownloadRoot>${npmRepositoryUrl}</npmDownloadRoot>
</configuration>
</execution>
<!-- Execute the script to remove node_modules and
package-lock.json -->
