This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 5ad9f488e [#1459][FOLLOWUP] improvement(server): Print an error log
when an event is dropped (#1643)
5ad9f488e is described below
commit 5ad9f488e2fb39bed82b479aa0f08275334810d5
Author: RickyMa <[email protected]>
AuthorDate: Sat Apr 13 20:22:59 2024 +0800
[#1459][FOLLOWUP] improvement(server): Print an error log when an event is
dropped (#1643)
### What changes were proposed in this pull request?
Print an error log when an event is dropped.
### Why are the changes needed?
A follow-up PR for: https://github.com/apache/incubator-uniffle/pull/1461.
This way, it's easier to find error logs in the log, making it convenient
for troubleshooting.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unnecessary.
---
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
b/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
index 15ea147d2..f75cbb68a 100644
--- a/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
+++ b/server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
@@ -111,7 +111,7 @@ public class ShuffleFlushManager {
}
if (reachRetryMax(event)) {
- LOG.warn("The event:{] has been reached to max retry times, it will be
dropped.", event);
+ LOG.error("The event:{] has been reached to max retry times, it will
be dropped.", event);
throw new EventDiscardException();
}