This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 9461d2233 [#1784] improvement(server): Skip retries for absent HDFS
app directory to speed up resource removal (#1785)
9461d2233 is described below
commit 9461d22334d903c259f9cd4f8b693d5e2bd64752
Author: xianjingfeng <[email protected]>
AuthorDate: Fri Jun 14 10:07:05 2024 +0800
[#1784] improvement(server): Skip retries for absent HDFS app directory to
speed up resource removal (#1785)
### What changes were proposed in this pull request?
Skip retries for absent HDFS app directory to speed up resource removal
### Why are the changes needed?
For better performance.
Fix: #1784
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual testing
---
.../uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git
a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java
b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java
index d48d72402..312f052f9 100644
---
a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java
+++
b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/HadoopShuffleDeleteHandler.java
@@ -17,6 +17,7 @@
package org.apache.uniffle.storage.handler.impl;
+import java.io.FileNotFoundException;
import java.io.IOException;
import org.apache.hadoop.conf.Configuration;
@@ -61,6 +62,10 @@ public class HadoopShuffleDeleteHandler implements
ShuffleDeleteHandler {
delete(fileSystem, path, shuffleServerId);
isSuccess = true;
} catch (Exception e) {
+ if (e instanceof FileNotFoundException) {
+ LOG.info("[{}] doesn't exist, ignore it.", path);
+ return;
+ }
times++;
LOG.warn(
"Can't delete shuffle data for appId[" + appId + "] with " +
times + " times", e);