This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 441fad037 [MINOR] fix(dashboard): Correct RegistrationTime to
HeartbeatTime (#1850)
441fad037 is described below
commit 441fad03716b43e72d599379a0ab43e9be3e6062
Author: maobaolong <[email protected]>
AuthorDate: Tue Jul 2 15:22:20 2024 +0800
[MINOR] fix(dashboard): Correct RegistrationTime to HeartbeatTime (#1850)
### What changes were proposed in this pull request?
The `RegistrationTime` in the dashboard shuffle-server page can make us
confuse, I think it could be better to be `HeartbeatTime`.
### Why are the changes needed?
Make the displayed title more meaningful.
### Does this PR introduce _any_ user-facing change?
WebUI of dashboard
### How was this patch tested?
<img width="2421" alt="image"
src="https://github.com/apache/incubator-uniffle/assets/17329931/b46a1560-9b17-4e63-88b4-465d2b83ff08";>
---
dashboard/src/main/webapp/src/pages/serverstatus/ActiveNodeListPage.vue | 2 +-
.../main/webapp/src/pages/serverstatus/DecommissionednodeListPage.vue | 2 +-
.../main/webapp/src/pages/serverstatus/DecommissioningNodeListPage.vue | 2 +-
dashboard/src/main/webapp/src/pages/serverstatus/LostNodeList.vue | 2 +-
.../src/main/webapp/src/pages/serverstatus/UnhealthyNodeListPage.vue | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/dashboard/src/main/webapp/src/pages/serverstatus/ActiveNodeListPage.vue
b/dashboard/src/main/webapp/src/pages/serverstatus/ActiveNodeListPage.vue
index 35166900b..659a3feb9 100644
--- a/dashboard/src/main/webapp/src/pages/serverstatus/ActiveNodeListPage.vue
+++ b/dashboard/src/main/webapp/src/pages/serverstatus/ActiveNodeListPage.vue
@@ -39,7 +39,7 @@
<el-table-column prop="status" label="Status" min-width="80" />
<el-table-column
prop="timestamp"
- label="RegistrationTime"
+ label="HeartbeatTime"
min-width="80"
:formatter="dateFormatter"
/>
diff --git
a/dashboard/src/main/webapp/src/pages/serverstatus/DecommissionednodeListPage.vue
b/dashboard/src/main/webapp/src/pages/serverstatus/DecommissionednodeListPage.vue
index cdcc3fb55..9e9f5f11b 100644
---
a/dashboard/src/main/webapp/src/pages/serverstatus/DecommissionednodeListPage.vue
+++
b/dashboard/src/main/webapp/src/pages/serverstatus/DecommissionednodeListPage.vue
@@ -39,7 +39,7 @@
<el-table-column prop="status" label="Status" min-width="80" />
<el-table-column
prop="timestamp"
- label="RegistrationTime"
+ label="HeartbeatTime"
min-width="80"
:formatter="dateFormatter"
/>
diff --git
a/dashboard/src/main/webapp/src/pages/serverstatus/DecommissioningNodeListPage.vue
b/dashboard/src/main/webapp/src/pages/serverstatus/DecommissioningNodeListPage.vue
index a289fa6b6..7633f5a77 100644
---
a/dashboard/src/main/webapp/src/pages/serverstatus/DecommissioningNodeListPage.vue
+++
b/dashboard/src/main/webapp/src/pages/serverstatus/DecommissioningNodeListPage.vue
@@ -39,7 +39,7 @@
<el-table-column prop="status" label="Status" min-width="80" />
<el-table-column
prop="timestamp"
- label="RegistrationTime"
+ label="HeartbeatTime"
min-width="80"
:formatter="dateFormatter"
/>
diff --git a/dashboard/src/main/webapp/src/pages/serverstatus/LostNodeList.vue
b/dashboard/src/main/webapp/src/pages/serverstatus/LostNodeList.vue
index 9beb8d881..f46d03f8e 100644
--- a/dashboard/src/main/webapp/src/pages/serverstatus/LostNodeList.vue
+++ b/dashboard/src/main/webapp/src/pages/serverstatus/LostNodeList.vue
@@ -39,7 +39,7 @@
<el-table-column prop="status" label="Status" min-width="80" />
<el-table-column
prop="timestamp"
- label="RegistrationTime"
+ label="HeartbeatTime"
min-width="80"
:formatter="dateFormatter"
/>
diff --git
a/dashboard/src/main/webapp/src/pages/serverstatus/UnhealthyNodeListPage.vue
b/dashboard/src/main/webapp/src/pages/serverstatus/UnhealthyNodeListPage.vue
index c568bf539..4472106c8 100644
--- a/dashboard/src/main/webapp/src/pages/serverstatus/UnhealthyNodeListPage.vue
+++ b/dashboard/src/main/webapp/src/pages/serverstatus/UnhealthyNodeListPage.vue
@@ -39,7 +39,7 @@
<el-table-column prop="status" label="Status" min-width="80" />
<el-table-column
prop="timestamp"
- label="RegistrationTime"
+ label="HeartbeatTime"
min-width="80"
:formatter="dateFormatter"
/>
