(incubator-uniffle) branch master updated: [MINOR] feat(common): Support set args from SystemProperties (#1909)

[zuston]

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new f32b526fe [MINOR] feat(common): Support set args from SystemProperties 
(#1909)
f32b526fe is described below

commit f32b526fe0e28071d50bffcee73a3b0d30e3a682
Author: maobaolong <baoloong...@tencent.com>
AuthorDate: Wed Jul 17 17:44:42 2024 +0800

    [MINOR] feat(common): Support set args from SystemProperties (#1909)
    
    ### What changes were proposed in this pull request?
    
    We can start server and specific arguments System.properties
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Add jvm args `-Drss.dashboard.http.port=19987` to start dashboard process, 
we can see it take effect through the log.
    
    ```
    [2024-07-15 21:56:55.942] [main] [INFO] AbstractConnector.doStart - Started 
ServerConnector@26be6ca7{HTTP/1.1,[http/1.1]}{0.0.0.0:19987}
    ```
    
    ---------
    
    Co-authored-by: xianjingfeng <xianjingfeng...@gmail.com>
---
 .../src/main/java/org/apache/uniffle/common/config/RssBaseConf.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java 
b/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
index 039d3c831..a0e6989ef 100644
--- a/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
+++ b/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
@@ -280,10 +280,14 @@ public class RssBaseConf extends RssConf {
 
   public boolean loadConfFromFile(String fileName, List<ConfigOption<Object>> 
configOptions) {
     Map<String, String> properties = RssUtils.getPropertiesFromFile(fileName);
-
     if (properties == null) {
       return false;
     }
+    System.getProperties().stringPropertyNames().stream()
+        .forEach(
+            propName -> {
+              properties.put(propName, System.getProperty(propName));
+            });
     return loadCommonConf(properties) && loadConf(properties, configOptions, 
true);
   }