This is an automated email from the ASF dual-hosted git repository.
xianjin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new b6a4364b4 chore(build): Disable lombok by default and only enable them
in web directories (#2024)
b6a4364b4 is described below
commit b6a4364b4f43a5765ebb57d9bb9f8c7045933c1e
Author: advancedxy <[email protected]>
AuthorDate: Fri Aug 9 23:56:56 2024 +0800
chore(build): Disable lombok by default and only enable them in web
directories (#2024)
### What changes were proposed in this pull request?
1. disable most of the lombok features in the project
2. enable specific lombok features in coordinator and shufffle server's web
directories
### Why are the changes needed?
For better code practice
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
---
.../apache/uniffle/coordinator/web/lombok.config | 21 ++++++++++++
lombok.config | 39 ++++++++++++++++++++++
.../org/apache/uniffle/server/web/lombok.config | 21 ++++++++++++
3 files changed, 81 insertions(+)
diff --git
a/coordinator/src/main/java/org/apache/uniffle/coordinator/web/lombok.config
b/coordinator/src/main/java/org/apache/uniffle/coordinator/web/lombok.config
new file mode 100644
index 000000000..d5b979224
--- /dev/null
+++ b/coordinator/src/main/java/org/apache/uniffle/coordinator/web/lombok.config
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+clear lombok.allArgsConstructor.flagUsage
+clear lombok.anyConstructor.flagUsage
+clear lombok.noArgsConstructor.flagUsage
+clear lombok.data.flagUsage
+clear lombok.builder.flagUsage
diff --git a/lombok.config b/lombok.config
new file mode 100644
index 000000000..8b5243580
--- /dev/null
+++ b/lombok.config
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+config.stopBubbling = true
+# Most of the lombok features are disabled by default as it might not be good
practice to use them
+# everywhere. It can be only enabled for source files under web directories,
which is a good place
+# to use them. Corresponding lombok features can be enabled in the
lombok.config file in the web
+# directories.
+lombok.anyConstructor.flagUsage = error
+lombok.allArgsConstructor.flagUsage = error
+lombok.noArgsConstructor.flagUsage = error
+lombok.requiredArgsConstructor.flagUsage = error
+lombok.data.flagUsage = error
+lombok.value.flagUsage = error
+lombok.builder.flagUsage = error
+lombok.getter.flagUsage = error
+lombok.setter.flagUsage = error
+lombok.with.flagUsage = error
+lombok.toString.flagUsage = error
+lombok.equalsAndHashCode.flagUsage = error
+lombok.log.flagUsage = error
+lombok.experimental.flagUsage = error
+lombok.var.flagUsage = error
+lombok.val.flagUsage = error
+lombok.delegate.flagUsage = error
+lombok.utilityClass.flagUsage = error
diff --git a/server/src/main/java/org/apache/uniffle/server/web/lombok.config
b/server/src/main/java/org/apache/uniffle/server/web/lombok.config
new file mode 100644
index 000000000..d5b979224
--- /dev/null
+++ b/server/src/main/java/org/apache/uniffle/server/web/lombok.config
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+clear lombok.allArgsConstructor.flagUsage
+clear lombok.anyConstructor.flagUsage
+clear lombok.noArgsConstructor.flagUsage
+clear lombok.data.flagUsage
+clear lombok.builder.flagUsage
