(incubator-uniffle) branch master updated: [MINOR] improvement(script): Support collect the output stream into out file (#2051)

[zuston]

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 801ded099 [MINOR] improvement(script): Support collect the output 
stream into out file (#2051)
801ded099 is described below

commit 801ded0993fe6bf75da8f2d8957915af7494f7e4
Author: maobaolong <baoloong...@tencent.com>
AuthorDate: Tue Aug 20 10:32:28 2024 +0800

    [MINOR] improvement(script): Support collect the output stream into out 
file (#2051)
    
    ### What changes were proposed in this pull request?
    
    Collect the standard out and error stream content into `xxx.out` file.
    
    ### Why are the changes needed?
    
    It can really help us for troubleshooting.  There are some exception throws 
but not caught, the call stack should be print in the `out` file.
    
    Reference what hadoop, alluxio did.
    
    ### Does this PR introduce _any_ user-facing change?
    
    Supply a out file.
    
    ### How was this patch tested?
    
    ```console
    $ bin/start-dashboard.sh
    $ cat logs/dashboard.out
    -XX:ConcGCThreads=5 -XX:InitialHeapSize=8589934592 
-XX:InitiatingHeapOccupancyPercent=45 -XX:MaxGCPauseMillis=200 
-XX:MaxHeapSize=8589934592 -XX:ParallelGCThreads=20 
-XX:+PrintAdaptiveSizePolicy -XX:+PrintCommandLineFlags -XX:+PrintGC 
-XX:+PrintGCApplicationStoppedTime -XX:+PrintGCCause -XX:+PrintGCDateStamps 
-XX:+PrintGCDetails -XX:+PrintGCTimeStamps -XX:+PrintPromotionFailure 
-XX:+PrintTenuringDistribution -XX:+UseCompressedClassPointers 
-XX:+UseCompressedOops -XX:+UseG1GC
    ```
---
 bin/start-coordinator.sh    | 3 ++-
 bin/start-dashboard.sh      | 4 ++--
 bin/start-shuffle-server.sh | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/bin/start-coordinator.sh b/bin/start-coordinator.sh
index 55b9c5439..439ff8c1c 100755
--- a/bin/start-coordinator.sh
+++ b/bin/start-coordinator.sh
@@ -30,6 +30,7 @@ COORDINATOR_CONF_FILE="${RSS_CONF_DIR}/coordinator.conf"
 JAR_DIR="${RSS_HOME}/jars"
 LOG_CONF_FILE="${RSS_CONF_DIR}/log4j2.xml"
 LOG_PATH="${RSS_LOG_DIR}/coordinator.log"
+LOG_OUT_PATH="${RSS_LOG_DIR}/coordinator.out"
 COORDINATOR_RPC_AUDIT_LOG_PATH="${RSS_LOG_DIR}/coordinator_rpc_audit.log"
 
 MAIN_CLASS="org.apache.uniffle.coordinator.CoordinatorServer"
@@ -111,7 +112,7 @@ else
 fi
 
 COORDINATOR_JAVA_OPTS=${COORDINATOR_JAVA_OPTS:-""}
-$RUNNER ${COORDINATOR_BASE_JVM_ARGS} ${COORDINATOR_JVM_GC_ARGS} 
${JVM_LOG_ARGS} ${COORDINATOR_JAVA_OPTS} -cp ${CLASSPATH} ${MAIN_CLASS} --conf 
"${COORDINATOR_CONF_FILE}" $@ &
+(nohup $RUNNER ${COORDINATOR_BASE_JVM_ARGS} ${COORDINATOR_JVM_GC_ARGS} 
${JVM_LOG_ARGS} ${COORDINATOR_JAVA_OPTS} -cp ${CLASSPATH} ${MAIN_CLASS} --conf 
"${COORDINATOR_CONF_FILE}" $@ > ${LOG_OUT_PATH} 2>&1) &
 
 get_pid_file_name coordinator
 echo $! >${RSS_PID_DIR}/${pid_file}
diff --git a/bin/start-dashboard.sh b/bin/start-dashboard.sh
index 358a50e99..1757655bc 100755
--- a/bin/start-dashboard.sh
+++ b/bin/start-dashboard.sh
@@ -30,6 +30,7 @@ DASHBOARD_CONF_FILE="${RSS_CONF_DIR}/dashboard.conf"
 JAR_DIR="${RSS_HOME}/jars"
 LOG_CONF_FILE="${RSS_CONF_DIR}/log4j2.xml"
 LOG_PATH="${RSS_LOG_DIR}/dashboard.log"
+LOG_OUT_PATH="${RSS_LOG_DIR}/dashboard.out"
 
 MAIN_CLASS="org.apache.uniffle.dashboard.web.Dashboard"
 
@@ -91,7 +92,6 @@ else
 fi
 
 DASHBOARD_JAVA_OPTS=${DASHBOARD_JAVA_OPTS:-""}
-$RUNNER ${DASHBOARD_BASE_JVM_ARGS} ${DASHBOARD_JVM_GC_ARGS} ${JVM_LOG_ARGS} 
${DASHBOARD_JAVA_OPTS} -cp ${CLASSPATH} ${MAIN_CLASS} --conf 
"${DASHBOARD_CONF_FILE}" $@ &
-
+(nohup $RUNNER ${DASHBOARD_BASE_JVM_ARGS} ${DASHBOARD_JVM_GC_ARGS} 
${JVM_LOG_ARGS} ${DASHBOARD_JAVA_OPTS} -cp ${CLASSPATH} ${MAIN_CLASS} --conf 
"${DASHBOARD_CONF_FILE}" $@ > ${LOG_OUT_PATH} 2>&1) &
 get_pid_file_name dashboard
 echo $! >${RSS_PID_DIR}/${pid_file}
diff --git a/bin/start-shuffle-server.sh b/bin/start-shuffle-server.sh
index b98c66799..b7077f0ef 100755
--- a/bin/start-shuffle-server.sh
+++ b/bin/start-shuffle-server.sh
@@ -30,6 +30,7 @@ SHUFFLE_SERVER_CONF_FILE="${RSS_CONF_DIR}/server.conf"
 JAR_DIR="${RSS_HOME}/jars"
 LOG_CONF_FILE="${RSS_CONF_DIR}/log4j2.xml"
 LOG_PATH="${RSS_LOG_DIR}/shuffle_server.log"
+LOG_OUT_PATH="${RSS_LOG_DIR}/shuffle_server.out"
 
SHUFFLE_SERVER_STORAGE_AUDIT_LOG_PATH=${SHUFFLE_SERVER_STORAGE_AUDIT_LOG_PATH:-"${RSS_LOG_DIR}/shuffle_server_storage_audit.log"}
 
SHUFFLE_SERVER_RPC_AUDIT_LOG_PATH=${SHUFFLE_SERVER_RPC_AUDIT_LOG_PATH:-"${RSS_LOG_DIR}/shuffle_server_rpc_audit.log"}
 
@@ -149,7 +150,7 @@ else
 fi
 
 SHUFFLE_SERVER_JAVA_OPTS=${SHUFFLE_SERVER_JAVA_OPTS:-""}
-$RUNNER ${SHUFFLE_SERVER_BASE_JVM_ARGS} ${SHUFFLE_SERVER_JVM_GC_ARGS} 
${JVM_LOG_ARGS} ${JAVA_LIB_PATH} ${SHUFFLE_SERVER_JAVA_OPTS} -cp ${CLASSPATH} 
${MAIN_CLASS} --conf "${SHUFFLE_SERVER_CONF_FILE}" $@ &
+(nohup $RUNNER ${SHUFFLE_SERVER_BASE_JVM_ARGS} ${SHUFFLE_SERVER_JVM_GC_ARGS} 
${JVM_LOG_ARGS} ${JAVA_LIB_PATH} ${SHUFFLE_SERVER_JAVA_OPTS} -cp ${CLASSPATH} 
${MAIN_CLASS} --conf "${SHUFFLE_SERVER_CONF_FILE}" $@ > ${LOG_OUT_PATH} 2>&1) &
 
 get_pid_file_name shuffle-server
 echo $! >${RSS_PID_DIR}/${pid_file}