(incubator-uniffle) branch master updated: fix(test): Fix flaky test about ShuffleServerMetricsTest#testStorageCounter (#2142)

[zuston]

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 422aa3695 fix(test): Fix flaky test about 
ShuffleServerMetricsTest#testStorageCounter (#2142)
422aa3695 is described below

commit 422aa36955b177bc4c8d9ef8f9062b11bbdc5002
Author: maobaolong <baoloong...@tencent.com>
AuthorDate: Thu Sep 26 12:01:26 2024 +0800

    fix(test): Fix flaky test about ShuffleServerMetricsTest#testStorageCounter 
(#2142)
    
    ### What changes were proposed in this pull request?
    
    Clear metrics in case of other test update the metrics value.
    
    ### Why are the changes needed?
    
    Fix the flaky test.
    
    ```
    Error:  Tests run: 7, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 
1.046 s <<< FAILURE! - in org.apache.uniffle.server.ShuffleServerMetricsTest
    Error:  testStorageCounter  Time elapsed: 0.008 s  <<< FAILURE!
    org.opentest4j.AssertionFailedError: expected: <1.0> but was: <3.0>
            at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
            at 
org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
            at 
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:86)
            at 
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:81)
            at 
org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1010)
            at 
org.apache.uniffle.server.ShuffleServerMetricsTest.testStorageCounter(ShuffleServerMetricsTest.java:176)
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    UT
---
 .../test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/server/src/test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java 
b/server/src/test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java
index c4462f1c2..58a31b47a 100644
--- 
a/server/src/test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java
+++ 
b/server/src/test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java
@@ -55,6 +55,7 @@ public class ShuffleServerMetricsTest {
 
   @BeforeAll
   public static void setUp() throws Exception {
+    ShuffleServerMetrics.clear();
     ShuffleServerConf ssc = new ShuffleServerConf();
     ssc.set(ShuffleServerConf.JETTY_HTTP_PORT, 12345);
     ssc.set(ShuffleServerConf.JETTY_CORE_POOL_SIZE, 128);