(incubator-uniffle) branch master updated: [MINOR] improve(script): Support customize Default Gc args (#2135)

[xianjin]

This is an automated email from the ASF dual-hosted git repository.

xianjin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new a283eb510 [MINOR] improve(script): Support customize Default Gc args 
(#2135)
a283eb510 is described below

commit a283eb510ddf568bc6e06c9bf31b8841af84fc0a
Author: maobaolong <baoloong...@tencent.com>
AuthorDate: Fri Sep 27 10:31:04 2024 +0800

    [MINOR] improve(script): Support customize Default Gc args (#2135)
    
    ### What changes were proposed in this pull request?
    Support customize default gc args.
    
    ### Why are the changes needed?
    We need to customize the gc related thread count. E.g. `ParallelGCThreads` 
and `ConcGCThreads`
    
    ### Does this PR introduce _any_ user-facing change?
    Support new variables named `XXX_DEFAULT_GC_ARGS`.
    
    ### How was this patch tested?
    By regression test
---
 bin/start-coordinator.sh    | 4 ++--
 bin/start-dashboard.sh      | 4 ++--
 bin/start-shuffle-server.sh | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/bin/start-coordinator.sh b/bin/start-coordinator.sh
index 439ff8c1c..a7211b317 100755
--- a/bin/start-coordinator.sh
+++ b/bin/start-coordinator.sh
@@ -68,11 +68,11 @@ COORDINATOR_BASE_JVM_ARGS=${COORDINATOR_BASE_JVM_ARGS:-" 
-server \
           -Xms${COORDINATOR_XMX_SIZE} \
           -XX:+PrintCommandLineFlags"}
 
-DEFAULT_GC_ARGS=" -XX:+UseG1GC \
+DEFAULT_GC_ARGS=${COORDINATOR_DEFAULT_GC_ARGS:-" -XX:+UseG1GC \
           -XX:MaxGCPauseMillis=200 \
           -XX:ParallelGCThreads=20 \
           -XX:ConcGCThreads=5 \
-          -XX:InitiatingHeapOccupancyPercent=45"
+          -XX:InitiatingHeapOccupancyPercent=45"}
 
 GC_LOG_ARGS_LEGACY=" -XX:+PrintGC \
           -XX:+PrintAdaptiveSizePolicy \
diff --git a/bin/start-dashboard.sh b/bin/start-dashboard.sh
index 1757655bc..ea2f1f968 100755
--- a/bin/start-dashboard.sh
+++ b/bin/start-dashboard.sh
@@ -54,11 +54,11 @@ DASHBOARD_BASE_JVM_ARGS=${DASHBOARD_BASE_JVM_ARGS:-" 
-server \
           -Xms${DASHBOARD_XMX_SIZE} \
           -XX:+PrintCommandLineFlags"}
 
-DEFAULT_GC_ARGS=" -XX:+UseG1GC \
+DEFAULT_GC_ARGS=${DASHBOARD_DEFAULT_GC_ARGS:-" -XX:+UseG1GC \
           -XX:MaxGCPauseMillis=200 \
           -XX:ParallelGCThreads=20 \
           -XX:ConcGCThreads=5 \
-          -XX:InitiatingHeapOccupancyPercent=45"
+          -XX:InitiatingHeapOccupancyPercent=45"}
 
 GC_LOG_ARGS_LEGACY=" -XX:+PrintGC \
           -XX:+PrintAdaptiveSizePolicy \
diff --git a/bin/start-shuffle-server.sh b/bin/start-shuffle-server.sh
index b7077f0ef..0807db205 100755
--- a/bin/start-shuffle-server.sh
+++ b/bin/start-shuffle-server.sh
@@ -104,13 +104,13 @@ 
SHUFFLE_SERVER_BASE_JVM_ARGS=${SHUFFLE_SERVER_BASE_JVM_ARGS:-" -server \
           -XX:+UnlockExperimentalVMOptions \
           -XX:+PrintCommandLineFlags"}
 
-DEFAULT_GC_ARGS=" -XX:+UseG1GC \
+DEFAULT_GC_ARGS=${SHUFFLE_SERVER_DEFAULT_GC_ARGS:-" -XX:+UseG1GC \
           -XX:MaxGCPauseMillis=200 \
           -XX:ParallelGCThreads=20 \
           -XX:ConcGCThreads=5 \
           -XX:InitiatingHeapOccupancyPercent=60 \
           -XX:G1HeapRegionSize=32m \
-          -XX:G1NewSizePercent=10"
+          -XX:G1NewSizePercent=10"}
 
 GC_LOG_ARGS_LEGACY=" -XX:+PrintGC \
           -XX:+PrintAdaptiveSizePolicy \