This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 812415250 improvement(spark): Simplify client output logs for 
writer/reader (#2660)
812415250 is described below

commit 8124152504ee823fbfdde7646cf812290f51c8de
Author: Junfan Zhang <[email protected]>
AuthorDate: Mon Nov 3 09:51:11 2025 +0800

    improvement(spark): Simplify client output logs for writer/reader (#2660)
    
    ### What changes were proposed in this pull request?
    
    Simplify client output logs for writer/reader
    
    ### Why are the changes needed?
    
    Too much unncessary logs are so mess
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Needn't
---
 .../apache/spark/shuffle/RssShuffleManager.java    |  2 +-
 .../client/impl/ShuffleWriteClientImpl.java        |  2 +-
 .../common/ShuffleServerPushCostTracker.java       | 40 ++++++++++++----------
 3 files changed, 23 insertions(+), 21 deletions(-)

diff --git 
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
 
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
index 3d1a69bb6..51cdc7218 100644
--- 
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
+++ 
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
@@ -433,7 +433,7 @@ public class RssShuffleManager extends 
RssShuffleManagerBase {
     }
 
     final RemoteStorageInfo shuffleRemoteStorageInfo = 
rssShuffleHandle.getRemoteStorage();
-    LOG.info("Shuffle reader using remote storage {}", 
shuffleRemoteStorageInfo);
+    LOG.debug("Shuffle reader using remote storage {}", 
shuffleRemoteStorageInfo);
     final String shuffleRemoteStoragePath = shuffleRemoteStorageInfo.getPath();
     Configuration readerHadoopConf =
         RssSparkShuffleUtils.getRemoteStorageHadoopConf(sparkConf, 
shuffleRemoteStorageInfo);
diff --git 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
index 3855debfa..25d17205a 100644
--- 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
+++ 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
@@ -778,7 +778,7 @@ public class ShuffleWriteClientImpl implements 
ShuffleWriteClient {
         RssReportShuffleResultResponse response =
             getShuffleServerClient(ssi).reportShuffleResult(request);
         if (response.getStatusCode() == StatusCode.SUCCESS) {
-          LOG.info(
+          LOG.debug(
               "Reported shuffle result to {} for appId[{}], shuffleId[{}] 
successfully that cost {} ms",
               ssi,
               appId,
diff --git 
a/internal-client/src/main/java/org/apache/uniffle/client/common/ShuffleServerPushCostTracker.java
 
b/internal-client/src/main/java/org/apache/uniffle/client/common/ShuffleServerPushCostTracker.java
index bc6ab049a..c361868ef 100644
--- 
a/internal-client/src/main/java/org/apache/uniffle/client/common/ShuffleServerPushCostTracker.java
+++ 
b/internal-client/src/main/java/org/apache/uniffle/client/common/ShuffleServerPushCostTracker.java
@@ -74,26 +74,28 @@ public class ShuffleServerPushCostTracker {
   }
 
   public void statistics() {
-    List<ShuffleServerPushCost> shuffleServerPushCosts = new 
ArrayList<>(this.tracking.values());
-    if (CollectionUtils.isEmpty(shuffleServerPushCosts)) {
-      return;
+    if (LOGGER.isDebugEnabled()) {
+      List<ShuffleServerPushCost> shuffleServerPushCosts = new 
ArrayList<>(this.tracking.values());
+      if (CollectionUtils.isEmpty(shuffleServerPushCosts)) {
+        return;
+      }
+
+      Collections.sort(
+          shuffleServerPushCosts, 
Comparator.comparingLong(ShuffleServerPushCost::speed));
+
+      LOGGER.debug(
+          "Statistics of shuffle server push speed: \n"
+              + "-------------------------------------------"
+              + "\nMinimum: {} \nP25: {} \nMedian: {} \nP75: {} \nMaximum: 
{}\n"
+              + "-------------------------------------------",
+          shuffleServerPushCosts.isEmpty() ? 0 : shuffleServerPushCosts.get(0),
+          getPercentile(shuffleServerPushCosts, 25),
+          getPercentile(shuffleServerPushCosts, 50),
+          getPercentile(shuffleServerPushCosts, 75),
+          shuffleServerPushCosts.isEmpty()
+              ? 0
+              : shuffleServerPushCosts.get(shuffleServerPushCosts.size() - 1));
     }
-
-    Collections.sort(
-        shuffleServerPushCosts, 
Comparator.comparingLong(ShuffleServerPushCost::speed));
-
-    LOGGER.info(
-        "Statistics of shuffle server push speed: \n"
-            + "-------------------------------------------"
-            + "\nMinimum: {} \nP25: {} \nMedian: {} \nP75: {} \nMaximum: {}\n"
-            + "-------------------------------------------",
-        shuffleServerPushCosts.isEmpty() ? 0 : shuffleServerPushCosts.get(0),
-        getPercentile(shuffleServerPushCosts, 25),
-        getPercentile(shuffleServerPushCosts, 50),
-        getPercentile(shuffleServerPushCosts, 75),
-        shuffleServerPushCosts.isEmpty()
-            ? 0
-            : shuffleServerPushCosts.get(shuffleServerPushCosts.size() - 1));
   }
 
   private ShuffleServerPushCost getPercentile(

Reply via email to