[unomi-tracker] 01/01: UNOMI-803 : set variant properly

[dgriffon]

This is an automated email from the ASF dual-hosted git repository.

dgriffon pushed a commit to branch fix-variant-without-event
in repository https://gitbox.apache.org/repos/asf/unomi-tracker.git

commit 528f0a1326d94c84a01020256ca7dea44fcaba87
Author: David Griffon <dgrif...@jahia.com>
AuthorDate: Thu Sep 7 18:49:35 2023 +0200

    UNOMI-803 : set variant properly
---
 src/apache-unomi-tracker.js | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/apache-unomi-tracker.js b/src/apache-unomi-tracker.js
index 6200dfd..d9ec84b 100644
--- a/src/apache-unomi-tracker.js
+++ b/src/apache-unomi-tracker.js
@@ -267,8 +267,7 @@ export const newTracker = () => {
             }
 
             // select random variant and call unomi
-            let selectVariant = variants[selectedVariantId];
-            if (!(selectedVariantId && selectVariant)) {
+            if (!(selectedVariantId && variants[selectedVariantId])) {
                 var keys = Object.keys(variants);
                 if (variantsTraffic) {
                     var rand = 100 * Math.random() << 0;
@@ -285,10 +284,10 @@ export const newTracker = () => {
                 } else {
                     wem.setCookie('selectedVariantId', selectedVariantId, 1);
                 }
-
+                const variant = variants[selectedVariantId];
                 // spread event to unomi
-                if (selectVariant.event) {
-                    
wem._registerEvent(wem._completeEvent(selectVariant.event));
+                if (variant.event) {
+                    wem._registerEvent(wem._completeEvent(variant.event));
                 }
             }
 
@@ -299,7 +298,7 @@ export const newTracker = () => {
                 }
 
                 // display the good variant
-                document.getElementById(selectVariant.content).style.display = 
'';
+                
document.getElementById(variants[selectedVariantId].content).style.display = '';
             }
         },