This is an automated email from the ASF dual-hosted git repository.
dgriffon pushed a commit to branch fix-variant-without-event
in repository https://gitbox.apache.org/repos/asf/unomi-tracker.git
commit 0fc862be43b19637fa3f9ffb0385379d0154bdab
Author: David Griffon <dgrif...@jahia.com>
AuthorDate: Thu Sep 7 18:49:35 2023 +0200
UNOMI-803 : set variant properly
---
dist/apache-unomi-tracker.cjs.js | 13 ++++++-------
dist/apache-unomi-tracker.cjs.js.map | 2 +-
dist/apache-unomi-tracker.esm.js | 13 ++++++-------
dist/apache-unomi-tracker.esm.js.map | 2 +-
dist/apache-unomi-tracker.umd.js | 13 ++++++-------
dist/apache-unomi-tracker.umd.js.map | 2 +-
src/apache-unomi-tracker.js | 11 +++++------
7 files changed, 26 insertions(+), 30 deletions(-)
diff --git a/dist/apache-unomi-tracker.cjs.js b/dist/apache-unomi-tracker.cjs.js
index 844826e..0b71c7a 100644
--- a/dist/apache-unomi-tracker.cjs.js
+++ b/dist/apache-unomi-tracker.cjs.js
@@ -293,9 +293,7 @@ var newTracker = function newTracker() {
} // select random variant and call unomi
- var selectVariant = variants[selectedVariantId];
-
- if (!(selectedVariantId && selectVariant)) {
+ if (!(selectedVariantId && variants[selectedVariantId])) {
var keys = Object.keys(variants);
if (variantsTraffic) {
@@ -314,11 +312,12 @@ var newTracker = function newTracker() {
sessionStorage.setItem(optimizationTestNodeId, selectedVariantId);
} else {
wem.setCookie('selectedVariantId', selectedVariantId, 1);
- } // spread event to unomi
+ }
+ var variant = variants[selectedVariantId]; // spread event to unomi
- if (selectVariant.event) {
- wem._registerEvent(wem._completeEvent(selectVariant.event));
+ if (variant.event) {
+ wem._registerEvent(wem._completeEvent(variant.event));
}
}
@@ -329,7 +328,7 @@ var newTracker = function newTracker() {
} // display the good variant
- document.getElementById(selectVariant.content).style.display = '';
+
document.getElementById(variants[selectedVariantId].content).style.display = '';
}
},
diff --git a/dist/apache-unomi-tracker.cjs.js.map
b/dist/apache-unomi-tracker.cjs.js.map
index 3fd2ca8..71a920a 100644
--- a/dist/apache-unomi-tracker.cjs.js.map
+++ b/dist/apache-unomi-tracker.cjs.js.map
@@ -1 +1 @@
-{"version":3,"file":"apache-unomi-tracker.cjs.js","sources":["../src/apache-unomi-tracker.js","../src/index.js"],"sourcesContent":["/*\n
* Licensed to the Apache Software Foundation (ASF) under one or more\n *
contributor license agreements. See the NOTICE file distributed with\n * this
work for additional information regarding copyright ownership.\n * The ASF
licenses this file to You under the Apache License, Version 2.0\n * (the
\"License\"); you may not use this file except in compl [...]
\ No newline at end of file
+{"version":3,"file":"apache-unomi-tracker.cjs.js","sources":["../src/apache-unomi-tracker.js","../src/index.js"],"sourcesContent":["/*\n
* Licensed to the Apache Software Foundation (ASF) under one or more\n *
contributor license agreements. See the NOTICE file distributed with\n * this
work for additional information regarding copyright ownership.\n * The ASF
licenses this file to You under the Apache License, Version 2.0\n * (the
\"License\"); you may not use this file except in compl [...]
\ No newline at end of file
diff --git a/dist/apache-unomi-tracker.esm.js b/dist/apache-unomi-tracker.esm.js
index af9ea4f..a01cd80 100644
--- a/dist/apache-unomi-tracker.esm.js
+++ b/dist/apache-unomi-tracker.esm.js
@@ -285,9 +285,7 @@ var newTracker = function newTracker() {
} // select random variant and call unomi
- var selectVariant = variants[selectedVariantId];
-
- if (!(selectedVariantId && selectVariant)) {
+ if (!(selectedVariantId && variants[selectedVariantId])) {
var keys = Object.keys(variants);
if (variantsTraffic) {
@@ -306,11 +304,12 @@ var newTracker = function newTracker() {
sessionStorage.setItem(optimizationTestNodeId, selectedVariantId);
} else {
wem.setCookie('selectedVariantId', selectedVariantId, 1);
- } // spread event to unomi
+ }
+ var variant = variants[selectedVariantId]; // spread event to unomi
- if (selectVariant.event) {
- wem._registerEvent(wem._completeEvent(selectVariant.event));
+ if (variant.event) {
+ wem._registerEvent(wem._completeEvent(variant.event));
}
}
@@ -321,7 +320,7 @@ var newTracker = function newTracker() {
} // display the good variant
- document.getElementById(selectVariant.content).style.display = '';
+
document.getElementById(variants[selectedVariantId].content).style.display = '';
}
},
diff --git a/dist/apache-unomi-tracker.esm.js.map
b/dist/apache-unomi-tracker.esm.js.map
index befc813..6fcbee0 100644
--- a/dist/apache-unomi-tracker.esm.js.map
+++ b/dist/apache-unomi-tracker.esm.js.map
@@ -1 +1 @@
-{"version":3,"file":"apache-unomi-tracker.esm.js","sources":["../src/apache-unomi-tracker.js","../src/index.js"],"sourcesContent":["/*\n
* Licensed to the Apache Software Foundation (ASF) under one or more\n *
contributor license agreements. See the NOTICE file distributed with\n * this
work for additional information regarding copyright ownership.\n * The ASF
licenses this file to You under the Apache License, Version 2.0\n * (the
\"License\"); you may not use this file except in compl [...]
\ No newline at end of file
+{"version":3,"file":"apache-unomi-tracker.esm.js","sources":["../src/apache-unomi-tracker.js","../src/index.js"],"sourcesContent":["/*\n
* Licensed to the Apache Software Foundation (ASF) under one or more\n *
contributor license agreements. See the NOTICE file distributed with\n * this
work for additional information regarding copyright ownership.\n * The ASF
licenses this file to You under the Apache License, Version 2.0\n * (the
\"License\"); you may not use this file except in compl [...]
\ No newline at end of file
diff --git a/dist/apache-unomi-tracker.umd.js b/dist/apache-unomi-tracker.umd.js
index 5014ca0..bad3cac 100644
--- a/dist/apache-unomi-tracker.umd.js
+++ b/dist/apache-unomi-tracker.umd.js
@@ -1940,9 +1940,7 @@
} // select random variant and call unomi
- var selectVariant = variants[selectedVariantId];
-
- if (!(selectedVariantId && selectVariant)) {
+ if (!(selectedVariantId && variants[selectedVariantId])) {
var keys = Object.keys(variants);
if (variantsTraffic) {
@@ -1961,11 +1959,12 @@
sessionStorage.setItem(optimizationTestNodeId, selectedVariantId);
} else {
wem.setCookie('selectedVariantId', selectedVariantId, 1);
- } // spread event to unomi
+ }
+ var variant = variants[selectedVariantId]; // spread event to unomi
- if (selectVariant.event) {
- wem._registerEvent(wem._completeEvent(selectVariant.event));
+ if (variant.event) {
+ wem._registerEvent(wem._completeEvent(variant.event));
}
}
@@ -1976,7 +1975,7 @@
} // display the good variant
- document.getElementById(selectVariant.content).style.display = '';
+
document.getElementById(variants[selectedVariantId].content).style.display = '';
}
},
diff --git a/dist/apache-unomi-tracker.umd.js.map
b/dist/apache-unomi-tracker.umd.js.map
index f6719a7..b68bb94 100644
--- a/dist/apache-unomi-tracker.umd.js.map
+++ b/dist/apache-unomi-tracker.umd.js.map
@@ -1 +1 @@
-{"version":3,"file":"apache-unomi-tracker.umd.js","sources":["../node_modules/@babel/runtime/helpers/esm/typeof.js","../node_modules/es6-crawler-detect/src/lib/crawler/provider.js","../node_modules/es6-crawler-detect/src/lib/crawler/crawlers.js","../node_modules/es6-crawler-detect/src/lib/crawler/exclusions.js","../node_modules/es6-crawler-detect/src/lib/crawler/headers.js","../node_modules/es6-crawler-detect/src/lib/crawler.js","../node_modules/es6-crawler-detect/src/index.js","../src/a
[...]
\ No newline at end of file
+{"version":3,"file":"apache-unomi-tracker.umd.js","sources":["../node_modules/@babel/runtime/helpers/esm/typeof.js","../node_modules/es6-crawler-detect/src/lib/crawler/provider.js","../node_modules/es6-crawler-detect/src/lib/crawler/crawlers.js","../node_modules/es6-crawler-detect/src/lib/crawler/exclusions.js","../node_modules/es6-crawler-detect/src/lib/crawler/headers.js","../node_modules/es6-crawler-detect/src/lib/crawler.js","../node_modules/es6-crawler-detect/src/index.js","../src/a
[...]
\ No newline at end of file
diff --git a/src/apache-unomi-tracker.js b/src/apache-unomi-tracker.js
index 6200dfd..d9ec84b 100644
--- a/src/apache-unomi-tracker.js
+++ b/src/apache-unomi-tracker.js
@@ -267,8 +267,7 @@ export const newTracker = () => {
}
// select random variant and call unomi
- let selectVariant = variants[selectedVariantId];
- if (!(selectedVariantId && selectVariant)) {
+ if (!(selectedVariantId && variants[selectedVariantId])) {
var keys = Object.keys(variants);
if (variantsTraffic) {
var rand = 100 * Math.random() << 0;
@@ -285,10 +284,10 @@ export const newTracker = () => {
} else {
wem.setCookie('selectedVariantId', selectedVariantId, 1);
}
-
+ const variant = variants[selectedVariantId];
// spread event to unomi
- if (selectVariant.event) {
-
wem._registerEvent(wem._completeEvent(selectVariant.event));
+ if (variant.event) {
+ wem._registerEvent(wem._completeEvent(variant.event));
}
}
@@ -299,7 +298,7 @@ export const newTracker = () => {
}
// display the good variant
- document.getElementById(selectVariant.content).style.display =
'';
+
document.getElementById(variants[selectedVariantId].content).style.display = '';
}
},
