Author: arkurth
Date: Thu Jul 13 21:21:27 2017
New Revision: 1801893

URL: http://svn.apache.org/viewvc?rev=1801893&view=rev
Log:
VCL-867
Added missing return statement to OS.pm::add_user_accounts if the call to 
create_user fails. add_user_accounts was returning true when a user account 
failed to be created. The reservation should fail when this happens.

Modified:
    vcl/trunk/managementnode/lib/VCL/Module/OS.pm

Modified: vcl/trunk/managementnode/lib/VCL/Module/OS.pm
URL: 
http://svn.apache.org/viewvc/vcl/trunk/managementnode/lib/VCL/Module/OS.pm?rev=1801893&r1=1801892&r2=1801893&view=diff
==============================================================================
--- vcl/trunk/managementnode/lib/VCL/Module/OS.pm (original)
+++ vcl/trunk/managementnode/lib/VCL/Module/OS.pm Thu Jul 13 21:21:27 2017
@@ -471,6 +471,8 @@ sub add_user_accounts {
                                if 
(!delete_reservation_account($reservation_id, $user_id)) {
                                        notify($ERRORS{'CRITICAL'}, 0, "failed 
to delete entry from reservationaccounts table for $username (ID: $user_id)");
                                }
+                               
+                               return;
                        }
                }
        }


Reply via email to