Author: nbubna
Date: Wed Aug  8 10:51:09 2007
New Revision: 563961

URL: http://svn.apache.org/viewvc?view=rev&rev=563961
Log:
fix backwards condition (found by FindBugs)

Modified:
    
velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/generic/ConversionTool.java

Modified: 
velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/generic/ConversionTool.java
URL: 
http://svn.apache.org/viewvc/velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/generic/ConversionTool.java?view=diff&rev=563961&r1=563960&r2=563961
==============================================================================
--- 
velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/generic/ConversionTool.java
 (original)
+++ 
velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/generic/ConversionTool.java
 Wed Aug  8 10:51:09 2007
@@ -174,7 +174,7 @@
      */
     public String toString(Collection values)
     {
-        if (values == null || !values.isEmpty())
+        if (values != null && !values.isEmpty())
         {
             return String.valueOf(values.iterator().next());
         }


Reply via email to