Author: nbubna
Date: Tue Aug 19 11:42:24 2008
New Revision: 687121

URL: http://svn.apache.org/viewvc?rev=687121&view=rev
Log:
VELOCITY-102 add support for static utility class' methods

Added:
    
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
   (with props)
Modified:
    
velocity/engine/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java

Modified: 
velocity/engine/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java
URL: 
http://svn.apache.org/viewvc/velocity/engine/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java?rev=687121&r1=687120&r2=687121&view=diff
==============================================================================
--- 
velocity/engine/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java
 (original)
+++ 
velocity/engine/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java
 Tue Aug 19 11:42:24 2008
@@ -195,8 +195,10 @@
         {
             return new VelMethodImpl(m);
         }
+
+        Class cls = obj.getClass();
         // if it's an array
-        if (obj.getClass().isArray())
+        if (cls.isArray())
         {
             // check for support via our array->list wrapper
             m = introspector.getMethod(ArrayListWrapper.class, methodName, 
args);
@@ -207,6 +209,15 @@
                 return new VelMethodImpl(m, true);
             }
         }
+        // watch for classes, to allow calling their static methods 
(VELOCITY-102)
+        else if (cls == Class.class)
+        {
+            m = introspector.getMethod((Class)obj, methodName, args);
+            if (m != null)
+            {
+                return new VelMethodImpl(m);
+            }
+        }
         return null;
     }
 

Added: 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
URL: 
http://svn.apache.org/viewvc/velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java?rev=687121&view=auto
==============================================================================
--- 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
 (added)
+++ 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
 Tue Aug 19 11:42:24 2008
@@ -0,0 +1,58 @@
+package org.apache.velocity.test;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.    
+ */
+
+import org.apache.velocity.VelocityContext;
+
+/**
+ * This class tests support for putting static utility classes
+ * like java.lang.Math directly into the context in order to
+ * use their methods.
+ */
+public class StaticUtilityMethodsTestCase extends BaseEvalTestCase
+{
+    public StaticUtilityMethodsTestCase(String name)
+    {
+       super(name);
+    }
+
+    public void testMath()
+    {
+        context.put("Math", Math.class);
+        assertEvalEquals("java.lang.Math", "$Math.name");
+        assertEvalEquals("3.0", "$Math.ceil(2.5)");
+    }
+
+    public void testFoo()
+    {
+        context.put("Foo", Foo.class);
+        assertEvalEquals("test", "$Foo.foo('test')");
+    }
+
+
+    public static class Foo
+    {
+        private Foo() {}
+        public static String foo(String s)
+        {
+            return s == null ? "foo" : s;
+        }
+    }
+}

Propchange: 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
------------------------------------------------------------------------------
    svn:executable = *

Propchange: 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
------------------------------------------------------------------------------
    svn:keywords = Revision

Propchange: 
velocity/engine/trunk/src/test/org/apache/velocity/test/StaticUtilityMethodsTestCase.java
------------------------------------------------------------------------------
    svn:mime-type = text/plain


Reply via email to