Author: cbrisson
Date: Thu Jan 26 02:20:53 2017
New Revision: 1780313
URL: http://svn.apache.org/viewvc?rev=1780313&view=rev
Log:
[engine] fix unnecessary use of StringBuffer instead of StringBuilder
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/app/event/implement/PrintExceptions.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/exception/MethodInvocationException.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Macro.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/MacroParseException.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Parse.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/VelocimacroProxy.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/ParseException.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/TemplateParseException.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ASTReference.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/BooleanPropertyExecutor.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/visitor/NodeViewMode.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ClassUtils.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ExtProperties.java
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/Introspector.java
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/BaseTestCase.java
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/VarargMethodsTestCase.java
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/provider/TestProvider.java
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/sql/HsqlDB.java
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/app/event/implement/PrintExceptions.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/app/event/implement/PrintExceptions.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/app/event/implement/PrintExceptions.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/app/event/implement/PrintExceptions.java
Thu Jan 26 02:20:53 2017
@@ -71,7 +71,7 @@ public class PrintExceptions implements
boolean showTemplateInfo = rs.getBoolean(SHOW_TEMPLATE_INFO, false);
boolean showStackTrace = rs.getBoolean(SHOW_STACK_TRACE,false);
- StringBuffer st = new StringBuffer();
+ StringBuilder st = new StringBuilder();
st.append("Exception while executing method
").append(claz.toString()).append(".").append(method);
st.append(": ").append(e.getClass().getName()).append(":
").append(e.getMessage());
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/exception/MethodInvocationException.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/exception/MethodInvocationException.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/exception/MethodInvocationException.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/exception/MethodInvocationException.java
Thu Jan 26 02:20:53 2017
@@ -131,7 +131,7 @@ public class MethodInvocationException e
*/
public String getMessage()
{
- StringBuffer message = new StringBuffer();
+ StringBuilder message = new StringBuilder();
message.append(super.getMessage());
message.append(" at ");
message.append(StringUtils.formatFileString(templateName, lineNumber,
columnNumber));
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Macro.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Macro.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Macro.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Macro.java
Thu Jan 26 02:20:53 2017
@@ -228,7 +228,7 @@ public class Macro extends Directive
if (debugMode)
{
- StringBuffer msg = new StringBuffer("Macro.getArgArray() :
nbrArgs=");
+ StringBuilder msg = new StringBuilder("Macro.getArgArray() :
nbrArgs=");
msg.append(numArgs).append(" : ");
macroToString(msg, macroArgs);
rsvc.getLog("macro").debug(msg.toString());
@@ -260,17 +260,17 @@ public class Macro extends Directive
* For debugging purposes. Formats the arguments from
* <code>argArray</code> and appends them to <code>buf</code>.
*
- * @param buf A StringBuffer. If null, a new StringBuffer is allocated.
+ * @param buf A StringBuilder. If null, a new StringBuilder is allocated.
* @param macroArgs Array of macro arguments, containing the
* #macro() arguments and default values. the 0th is the name.
- * @return A StringBuffer containing the formatted arguments. If a
StringBuffer
+ * @return A StringBuilder containing the formatted arguments. If a
StringBuilder
* has passed in as buf, this method returns it.
* @since 1.5
*/
- public static final StringBuffer macroToString(final StringBuffer buf,
+ public static final StringBuilder macroToString(final StringBuilder buf,
List<MacroArg> macroArgs)
{
- StringBuffer ret = (buf == null) ? new StringBuffer() : buf;
+ StringBuilder ret = (buf == null) ? new StringBuilder() : buf;
ret.append('#').append(macroArgs.get(0).name).append("( ");
for (MacroArg marg : macroArgs)
@@ -285,5 +285,5 @@ public class Macro extends Directive
ret.append(" )");
return ret;
}
-
+
}
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/MacroParseException.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/MacroParseException.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/MacroParseException.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/MacroParseException.java
Thu Jan 26 02:20:53 2017
@@ -124,14 +124,14 @@ public class MacroParseException
{
if (!specialConstructor)
{
- StringBuffer sb = new StringBuffer(super.getMessage());
+ StringBuilder sb = new StringBuilder(super.getMessage());
appendTemplateInfo(sb);
return sb.toString();
}
int maxSize = 0;
- StringBuffer expected = new StringBuffer();
+ StringBuilder expected = new StringBuilder();
for (int i = 0; i < expectedTokenSequences.length; i++)
{
@@ -153,7 +153,7 @@ public class MacroParseException
expected.append(eol).append(" ");
}
- StringBuffer retval = new StringBuffer("Encountered \"");
+ StringBuilder retval = new StringBuilder("Encountered \"");
Token tok = currentToken.next;
for (int i = 0; i < maxSize; i++)
@@ -194,7 +194,7 @@ public class MacroParseException
* @param sb
* @since 1.5
*/
- protected void appendTemplateInfo(final StringBuffer sb)
+ protected void appendTemplateInfo(final StringBuilder sb)
{
sb.append(StringUtils.formatFileString(getTemplateName(),
getLineNumber(), getColumnNumber()));
sb.append(eol);
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Parse.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Parse.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Parse.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Parse.java
Thu Jan 26 02:20:53 2017
@@ -192,7 +192,7 @@ public class Parse extends InputBase
String[] templateStack = context.getTemplateNameStack();
if (templateStack.length >= maxDepth)
{
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder();
for( int i = 0; i < templateStack.length; ++i)
{
path.append( " > " + templateStack[i] );
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/VelocimacroProxy.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/VelocimacroProxy.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/VelocimacroProxy.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/VelocimacroProxy.java
Thu Jan 26 02:20:53 2017
@@ -272,7 +272,7 @@ public class VelocimacroProxy extends Di
{
String[] stack = context.getMacroNameStack();
- StringBuffer out = new StringBuffer(100)
+ StringBuilder out = new StringBuilder(100)
.append("Max calling depth of ").append(maxCallDepth)
.append(" was exceeded in macro '").append(macroName)
.append("' with Call Stack:");
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/ParseException.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/ParseException.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/ParseException.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/ParseException.java
Thu Jan 26 02:20:53 2017
@@ -168,7 +168,7 @@ public class ParseException extends Exce
* string literal.
*/
protected String add_escapes(String str) {
- StringBuffer retval = new StringBuffer();
+ StringBuilder retval = new StringBuilder();
char ch;
for (int i = 0; i < str.length(); i++) {
switch (str.charAt(i))
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/TemplateParseException.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/TemplateParseException.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/TemplateParseException.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/TemplateParseException.java
Thu Jan 26 02:20:53 2017
@@ -162,14 +162,14 @@ public class TemplateParseException
{
if (!specialConstructor)
{
- StringBuffer sb = new StringBuffer(super.getMessage());
+ StringBuilder sb = new StringBuilder(super.getMessage());
appendTemplateInfo(sb);
return sb.toString();
}
int maxSize = 0;
- StringBuffer expected = new StringBuffer();
+ StringBuilder expected = new StringBuilder();
for (int i = 0; i < expectedTokenSequences.length; i++)
{
@@ -191,7 +191,7 @@ public class TemplateParseException
expected.append(eol).append(" ");
}
- StringBuffer retval = new StringBuffer("Encountered \"");
+ StringBuilder retval = new StringBuilder("Encountered \"");
Token tok = currentToken.next;
for (int i = 0; i < maxSize; i++)
@@ -231,7 +231,7 @@ public class TemplateParseException
/**
* @param sb
*/
- protected void appendTemplateInfo(final StringBuffer sb)
+ protected void appendTemplateInfo(final StringBuilder sb)
{
sb.append(StringUtils.formatFileString(getTemplateName(),
getLineNumber(), getColumnNumber()));
sb.append(eol);
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ASTReference.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ASTReference.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ASTReference.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ASTReference.java
Thu Jan 26 02:20:53 2017
@@ -328,7 +328,7 @@ public class ASTReference extends Simple
referenceType != QUIET_REFERENCE &&
(!onlyTestingReference || failedChild <
jjtGetNumChildren() - 1))
{
- StringBuffer name = new
StringBuffer("$").append(rootString);
+ StringBuilder name = new
StringBuilder("$").append(rootString);
for (int i = 0; i <= failedChild; i++)
{
Node node = jjtGetChild(i);
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/BooleanPropertyExecutor.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/BooleanPropertyExecutor.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/BooleanPropertyExecutor.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/BooleanPropertyExecutor.java
Thu Jan 26 02:20:53 2017
@@ -71,7 +71,7 @@ public class BooleanPropertyExecutor ext
{
Object [] params = {};
- StringBuffer sb = new StringBuffer("is");
+ StringBuilder sb = new StringBuilder("is");
sb.append(property);
setMethod(getIntrospector().getMethod(clazz, sb.toString(),
params));
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/PropertyExecutor.java
Thu Jan 26 02:20:53 2017
@@ -95,7 +95,7 @@ public class PropertyExecutor extends Ab
{
Object [] params = {};
- StringBuffer sb = new StringBuffer("get");
+ StringBuilder sb = new StringBuilder("get");
sb.append(property);
setMethod(introspector.getMethod(clazz, sb.toString(), params));
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java
Thu Jan 26 02:20:53 2017
@@ -224,7 +224,7 @@ public class ResourceManagerImpl
* pertaining to a particular loader.
*/
String loaderName = (String) it.next();
- StringBuffer loaderID = new StringBuffer(loaderName);
+ StringBuilder loaderID = new StringBuilder(loaderName);
loaderID.append(".").append(RuntimeConstants.RESOURCE_LOADER);
ExtProperties loaderConfiguration =
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/visitor/NodeViewMode.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/visitor/NodeViewMode.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/visitor/NodeViewMode.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/runtime/visitor/NodeViewMode.java
Thu Jan 26 02:20:53 2017
@@ -43,7 +43,7 @@ public class NodeViewMode extends BaseVi
*/
private String indentString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (int i = 0; i < indent; ++i)
{
sb.append(" ");
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ClassUtils.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ClassUtils.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ClassUtils.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ClassUtils.java
Thu Jan 26 02:20:53 2017
@@ -221,7 +221,7 @@ public class ClassUtils {
if (strictRef)
{
// Create a parameter list for the exception error message
- StringBuffer plist = new StringBuffer();
+ StringBuilder plist = new StringBuilder();
for (int i = 0; i < params.length; i++)
{
Class param = paramClasses[i];
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ExtProperties.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ExtProperties.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ExtProperties.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/ExtProperties.java
Thu Jan 26 02:20:53 2017
@@ -253,7 +253,7 @@ public class ExtProperties extends Hasht
int end = -1;
int prec = 0 - END_TOKEN.length();
String variable = null;
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
// FIXME: we should probably allow the escaping of the start token
while (((begin = base.indexOf(START_TOKEN, prec + END_TOKEN.length()))
> -1)
@@ -265,7 +265,7 @@ public class ExtProperties extends Hasht
if (priorVariables.contains(variable)) {
String initialBase = priorVariables.remove(0).toString();
priorVariables.add(variable);
- StringBuffer priorVariableSb = new StringBuffer();
+ StringBuilder priorVariableSb = new StringBuilder();
// create a nice trace of interpolated variables like so:
// var1->var2->var3
@@ -311,7 +311,7 @@ public class ExtProperties extends Hasht
* Inserts a backslash before every comma and backslash.
*/
private static String escape(String s) {
- StringBuffer buf = new StringBuffer(s);
+ StringBuilder buf = new StringBuilder(s);
for (int i = 0; i < buf.length(); i++) {
char c = buf.charAt(i);
if (c == ',' || c == '\\') {
@@ -326,7 +326,7 @@ public class ExtProperties extends Hasht
* Removes a backslash from every pair of backslashes.
*/
private static String unescape(String s) {
- StringBuffer buf = new StringBuffer(s);
+ StringBuilder buf = new StringBuilder(s);
for (int i = 0; i < buf.length() - 1; i++) {
char c1 = buf.charAt(i);
char c2 = buf.charAt(i + 1);
@@ -384,7 +384,7 @@ public class ExtProperties extends Hasht
* @throws IOException if there is difficulty reading the source.
*/
public String readProperty() throws IOException {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
String line = readLine();
while (line != null) {
line = line.trim();
@@ -438,7 +438,7 @@ public class ExtProperties extends Hasht
* @return A String.
*/
public String nextToken() {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
while (hasMoreTokens()) {
String token = super.nextToken();
@@ -769,7 +769,7 @@ public class ExtProperties extends Hasht
Object value = get(key);
if (value != null) {
if (value instanceof String) {
- StringBuffer currentOutput = new StringBuffer();
+ StringBuilder currentOutput = new StringBuilder();
currentOutput.append(key);
currentOutput.append("=");
currentOutput.append(escape((String) value));
@@ -779,7 +779,7 @@ public class ExtProperties extends Hasht
List values = (List) value;
for (Iterator it = values.iterator(); it.hasNext(); ) {
String currentElement = (String) it.next();
- StringBuffer currentOutput = new StringBuffer();
+ StringBuilder currentOutput = new StringBuilder();
currentOutput.append(key);
currentOutput.append("=");
currentOutput.append(escape(currentElement));
Modified:
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/Introspector.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/Introspector.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/Introspector.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/main/java/org/apache/velocity/util/introspection/Introspector.java
Thu Jan 26 02:20:53 2017
@@ -98,7 +98,7 @@ public class Introspector extends Intros
* whoops. Ambiguous. Make a nice log message and return null...
*/
- StringBuffer msg = new StringBuffer("Introspection Error :
Ambiguous method invocation ")
+ StringBuilder msg = new StringBuilder("Introspection Error :
Ambiguous method invocation ")
.append(name)
.append("(");
Modified:
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/BaseTestCase.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/BaseTestCase.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/BaseTestCase.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/BaseTestCase.java
Thu Jan 26 02:20:53 2017
@@ -344,7 +344,7 @@ public abstract class BaseTestCase exten
protected String getFileName(final String dir, final String base, final
String ext, final boolean mustExist)
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
try
{
File baseFile = new File(base);
@@ -537,7 +537,7 @@ public abstract class BaseTestCase exten
*/
protected static final String getTestCaseName(String s)
{
- StringBuffer name = new StringBuffer();
+ StringBuilder name = new StringBuilder();
name.append(Character.toTitleCase(s.charAt(0)));
name.append(s.substring(1, s.length()).toLowerCase(Locale.ROOT));
return name.toString();
Modified:
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/VarargMethodsTestCase.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/VarargMethodsTestCase.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/VarargMethodsTestCase.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/VarargMethodsTestCase.java
Thu Jan 26 02:20:53 2017
@@ -136,7 +136,7 @@ public class VarargMethodsTestCase exten
{
public String var(String[] ss)
{
- StringBuffer out = new StringBuffer();
+ StringBuilder out = new StringBuilder();
for (int i=0; i < ss.length; i++)
{
out.append(ss[i]);
@@ -220,7 +220,7 @@ public class VarargMethodsTestCase exten
{
return null;
}
- StringBuffer o = new StringBuffer("[");
+ StringBuilder o = new StringBuilder("[");
for (int i=0; i < array.length; i++)
{
if (i > 0)
Modified:
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/provider/TestProvider.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/provider/TestProvider.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/provider/TestProvider.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/provider/TestProvider.java
Thu Jan 26 02:20:53 2017
@@ -211,7 +211,7 @@ public class TestProvider
public String concat(Object[] strings)
{
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
for (int i = 0; i < strings.length; i++)
{
@@ -223,7 +223,7 @@ public class TestProvider
public String concat(List strings)
{
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
for (int i = 0; i < strings.size(); i++)
{
@@ -235,7 +235,7 @@ public class TestProvider
public String objConcat(List objects)
{
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
for (int i = 0; i < objects.size(); i++)
{
Modified:
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/sql/HsqlDB.java
URL:
http://svn.apache.org/viewvc/velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/sql/HsqlDB.java?rev=1780313&r1=1780312&r2=1780313&view=diff
==============================================================================
---
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/sql/HsqlDB.java
(original)
+++
velocity/engine/trunk/velocity-engine-core/src/test/java/org/apache/velocity/test/sql/HsqlDB.java
Thu Jan 26 02:20:53 2017
@@ -91,7 +91,7 @@ public class HsqlDB {
fr = new FileReader(fileName);
char[] fileBuf = new char[1024];
- StringBuffer sb = new StringBuffer(1000);
+ StringBuilder sb = new StringBuilder(1000);
int res = -1;
while ((res = fr.read(fileBuf, 0, 1024)) > -1) {
