kbeedkar commented on PR #311: URL: https://github.com/apache/incubator-wayang/pull/311#issuecomment-1529610595
Hi guys, I went through the code. Overall, while the PR extends WayangContext, it does not affect any existing methods so this should not break anything. A few other issues with the code are 1. package name should start in lowercase, also there is a typo (Intefaces --> interfaces) 2. package names should be more meaningful and be consistent with the code base. spark_monitoring --> spark-monitoring. I would suggest having another meaningful name as the package is already under /spark/monitoring 3. Comments should not have @author tags (or?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
