2pk03 commented on PR #322: URL: https://github.com/apache/incubator-wayang/pull/322#issuecomment-1546212814
> Hi, thank you for your comment. This is something that can be improved, unfortunately, given the limitations of this research project, we don't have resources to do that right now. Also, there are definitely more stuff that could be improved. In our opinion, this PR is still an improvement since it 1) gets rid of all the hard coded parts 2) cuts severely down on the lines of code that the user has to provide to run a query and 3) adds the functionality to provide delimiters/separators for csv-files. Yes, in terms of future maintainability/extensibility we agree with you, but it requires resources that we don't have right now. > > We hope that your suggestions can be implemented in another PR :) Pls add the license header: https://github.com/apache/incubator-wayang/actions/runs/4948812486/jobs/8880546014?pr=322#step:3:127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
