kbeedkar commented on code in PR #347:
URL: https://github.com/apache/incubator-wayang/pull/347#discussion_r1349846086
##########
wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlTest.java:
##########
Review Comment:
@AdityaGoel11 please undo the changes to this file. This test class has
nothing to do with SQL queries with aggregations.
##########
wayang-api/wayang-api-sql/src/test/resources/model.json:
##########
@@ -1,24 +1,16 @@
{
- "version": '1.0',
- "defaultSchema": 'wayang',
+ "version": "1.0",
+ "defaultSchema": "wayang",
"schemas": [
{
- "name": 'postgres',
- "type": 'custom',
- "factory": 'org.apache.wayang.api.sql.calcite.jdbc.JdbcSchema$Factory',
+ "name": "postgres",
+ "type": "custom",
+ "factory": "org.apache.wayang.api.sql.calcite.jdbc.JdbcSchema$Factory",
"operand": {
- "jdbcDriver": 'org.postgresql.Driver',
- "jdbcUrl": 'jdbc:postgresql://localhost:5432/imdb',
- "jdbcUser": 'postgres',
- "jdbcPassword": 'postgres'
- }
- },
- {
- "name": 'fs',
- "type": 'custom',
- "factory": 'org.apache.calcite.adapter.file.FileSchemaFactory',
- "operand": {
- "directory":
'C:/incubator-Wayang-CrossPlatform/incubator-wayang-SQL/wayang-api/wayang-api-sql/src/test/resources'
+ "jdbcDriver": "org.postgresql.Driver",
+ "jdbcUrl": "jdbc:postgresql://localhost:5432/dvdrental",
+ "jdbcUser": "aditya",
Review Comment:
@AdityaGoel11 Do not delete the fs schema, it is meant to support SQL
queries over csv files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
