juripetersen commented on code in PR #638:
URL: https://github.com/apache/incubator-wayang/pull/638#discussion_r2601479912
##########
wayang-platforms/wayang-flink/src/main/java/org/apache/wayang/flink/operators/FlinkObjectFileSink.java:
##########
@@ -80,8 +88,14 @@ public Tuple<Collection<ExecutionLineageNode>,
Collection<ChannelInstance>> eval
//TODO: remove the set parallelism 1
DataSetChannel.Instance input = (DataSetChannel.Instance) inputs[0];
+ ObjectFileSerializationMode serializationMode =
this.getSerializationMode();
+ if (serializationMode ==
ObjectFileSerializationMode.LEGACY_JAVA_SERIALIZATION) {
Review Comment:
This is repeated in every implementation extending ObjectFileSink, so it
should just be moved there and called here for checking the serializationMode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
