treyfel commented on PR #652:
URL: https://github.com/apache/wayang/pull/652#issuecomment-3720867538

   > ty for your contribution,
   > 
   > I'm not entirely sure I understand the issue you are trying to fix here, 
`JdbcJoinOperator.createSqlClause()` now uses the right table name twice, but 
what about the left table name then?
   > 
   The left table name comes from the tableSource 
`JdbcTableSource.createSqlClause()`.
   > Can I ask what issue prompted the change? If you have a stack trace or 
something I can also take a look at it.
   >
   There was no initial issue as the tests we’re green but when working on 
something regarding join operations on the jdbc platform, I noticed the test 
checks for a self join syntax, which I assume was not intended.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to