juripetersen commented on PR #656: URL: https://github.com/apache/wayang/pull/656#issuecomment-3754338323
> Hi, > > 1. The build error is fixed now. There was a unambiogus reference with the CardinalityEstimator, when i removed the full qualification. I have readded this. > > 2. In regards to writing some test i am bit unsure how to do this. The problem is that when we Write to an iceberg table, it expects a folder location where a Iceberg location is already created. Also it expects some data to write to. This data can of course be generated by just creating a few Wayang Records. But when writing the data it will create a lots of files within the folder as there are metadata files actual data files and other various things needed for an Iceberg Table. > > > * In regards to loading from a table, this also expects that an Iceberg warehouse has been created. This can definitely be solved, but doing it automated and ensuring that everything is cleaned up correctly after the test is not something that i have looked into. I can point to a reasearch paper that i have created with Zoi, where you can see the validation. If it is a requirement that the testing should be added for the operators i would like to setup a meeting where we can discuss the different possibilties. I am not so familiar with writing automated testing and ensuring that it does not cause errors for other users. If you need the research paper for reference for evaluation for the operators then let me know and i can send it over. > > > Let me know how we should proceed. We ususally use Mockito, which can be utilized to mock things that would be impractical to set up in tests: https://github.com/apache/wayang/blob/392b3e3a0670d0d4d32402a8b04ef88a946ef60e/wayang-commons/wayang-core/src/test/java/org/apache/wayang/core/platform/PartialExecutionTest.java#L52 It's basically used to fake the API of the thing you are interacting with, so that unit testing is possible. Do you think this would be feasible for testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
