mattpapp commented on PR #695: URL: https://github.com/apache/wayang/pull/695#issuecomment-3944781354
@mspruc Hey! good question. I don’t think `BasicDataUnitType` should include `super.hashCode()`. Its superclass (`DataUnitType`) doesn’t override `hashCode`/`equals` (adn has no state) so `super.hashCode()` would basically be `Object.hashCode()` and would make two equal `BasicDataUnitType` instances give different hashes. `RecordType` including `super.hashCode()` is still correct since `RecordType.equals()` calls `super.equals()` (so the parent state/typeClass is part of equality) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
