JunWang222 commented on PR #794: URL: https://github.com/apache/wayang/pull/794#issuecomment-5548413288
> Hi @JunWang222, As mentioned in Issue #796, I think we need to address the setup and platform specific files like docker-compose.yml in this PR as well. > > Can you take a look at the issue and the problems I pointed out there and also see where this PR can be adapted to fit my description. > > Thank you! Thanks for clarifying this in #796. I agree that having demos and setup projects in several different locations makes the conventions harder to follow. For this PR, I propose moving the DuckDB demo into wayang-applications, removing the standalone Docker-based setup project, and updating the documentation to run the example directly through JDBC with a configurable database path. DuckDB is embedded, so Docker is not necessary for this workflow. Platform integration tests would remain in the DuckDB module. I’ll also review the profiling scripts and configuration currently under the setup directory and move the relevant pieces into the appropriate existing module. For the existing Presto, Trino, and BigQuery setup files and OS-specific scripts mentioned in #796, I suggest handling that cleanup in a separate PR so this one stays focused on DuckDB. Would that scope work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
