JunWang222 commented on code in PR #793:
URL: https://github.com/apache/wayang/pull/793#discussion_r4437320389
##########
wayang-platforms/wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/operators/JdbcJoinOperator.java:
##########
@@ -66,11 +66,17 @@ public JdbcJoinOperator(JoinOperator<Record, Record,
KeyType> that) {
@Override
public String createSqlClause(Connection connection, FunctionCompiler
compiler) {
+ return this.createSqlClause(connection, compiler, null);
+ }
+
+ @Override
+ public String createSqlClause(Connection connection, FunctionCompiler
compiler, Configuration configuration) {
final Tuple<String, String> left =
this.keyDescriptor0.getSqlImplementation();
final Tuple<String, String> right =
this.keyDescriptor1.getSqlImplementation();
- final String leftTableName = left.field0;
+ final String platformId = this.getPlatform().getPlatformId();
+ final String leftTableName =
JdbcParquetSource.resolveSourceName(configuration, platformId, left.field0);
final String leftKeys = left.field1;
- final String rightTableName = right.field0;
+ final String rightTableName =
JdbcParquetSource.resolveSourceName(configuration, platformId, right.field0);
Review Comment:
Hi Zoi, I moved the source-name resolution to the executor/source operators,
so JdbcJoinOperator is now source-agnostic. I also added coverage to ensure
regular table sources are not affected by Parquet mappings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]