AliRana30 commented on PR #838:
URL: https://github.com/apache/wayang/pull/838#issuecomment-6670918031
hi @novatechflow Thanks for the thorough review and security probe findings!
All three issues along with additional Java 17 edge cases have been resolved
and covered by regression tests:
1. **Custom `Number` & Arbitrary Subclass Hooks:**
- Removed `targetComponent.isAssignableFrom(...)` and prohibited custom
subclasses of `Number`, `Collection`, and `Map`.
- Concrete custom payload types require exact class matches (allowing
inner/nested member classes of the payload only if they are not
collection/map/number subclasses).
- Broadened boundary checks (`AutoCloseable`, `Closeable`, `Throwable`,
`Exception`, `Error`, `Enum`, `Record`).
2. **Package Trust Elimination:**
- Removed `targetComponent.getPackage()` prefix matching so selecting a
payload class will not allow unrelated classes in the same package.
- Narrowed Wayang internal types from `org.apache.wayang.*` down to
explicit core data structures (`Record`, `Tuple2`, `Tuple5`, `Tuple`, `Op`,
`WayangValue`, `WayangListValue`).
3. **Fresh No-Argument `WayangValue` Deserialization:**
- Updated `WayangValue.write/read` to persist and securely resolve the
payload class against `Serializable`, dynamically configuring the
deserialization filter with the expected custom type.
- Tested single and collection (`WayangListValue`) round-trips for fresh
no-arg instances with custom payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]