Github user cxfeng1 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/539#discussion_r129747806
  
    --- Diff: ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m 
---
    @@ -89,6 +96,15 @@ @interface WXRecyclerComponent () 
<UICollectionViewDataSource, UICollectionViewD
     @property (nonatomic, strong, readonly) WXRecyclerDataController 
*dataController;
     @property (nonatomic, strong, readonly) WXRecyclerUpdateController 
*updateController;
     @property (nonatomic, weak, readonly) UICollectionView *collectionView;
    +@property (nonatomic, strong) UILongPressGestureRecognizer 
*currentLongPress;
    +@property (nonatomic, strong) NSIndexPath  *startIndexPath;
    +@property (nonatomic, strong) NSIndexPath  *dragingIndexPath;
    +@property (nonatomic, strong) NSIndexPath  *targetIndexPath;
    +@property (nonatomic, strong) NSMutableArray *excludedAry;
    +@property (nonatomic, strong) UICollectionViewCell *dragingCell;
    +@property (nonatomic, assign) BOOL isDragable;
    +@property (nonatomic, assign) BOOL isDragAnchor;
    +@property (nonatomic, assign) WXRecyclerDragTriggerType dragTriggerType;
    --- End diff --
    
    Too many properties in WXRecyclerComponent,I suppose creating a single 
class to handle dragging, just as WXRecyclerUpdateController.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to