reduce unused code and reuse hashmap
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/6d9be145 Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/6d9be145 Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/6d9be145 Branch: refs/heads/website Commit: 6d9be1457300955f556617b01018094ff970fe15 Parents: 72a852b Author: jianbai.gbj <jianbai....@alibaba-inc.com> Authored: Mon Oct 9 19:52:50 2017 +0800 Committer: gurisxie <279483...@qq.com> Committed: Tue Oct 10 12:11:25 2017 +0800 ---------------------------------------------------------------------- android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java | 6 +----- .../sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java | 2 +- .../sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java | 2 +- .../main/java/com/taobao/weex/ui/component/WXComponent.java | 2 +- .../java/com/taobao/weex/ui/component/binding/Statements.java | 1 + 5 files changed, 5 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/6d9be145/android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java b/android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java index f990792..782b16c 100644 --- a/android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java +++ b/android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java @@ -138,9 +138,6 @@ public class WXDomObject extends CSSNode implements Cloneable,ImmutableDomObject return mRef; } - public void setRef(String ref) { - this.mRef = ref; - } public String getType(){ return mType; @@ -169,7 +166,6 @@ public class WXDomObject extends CSSNode implements Cloneable,ImmutableDomObject } - public @NonNull DomContext getDomContext() { return mDomContext; } @@ -466,7 +462,7 @@ public class WXDomObject extends CSSNode implements Cloneable,ImmutableDomObject super.dirty(); } - /** package **/public void applyStyleToNode() { + /** package **/ void applyStyleToNode() { WXStyle stylesMap = getStyles(); int vp = getViewPortWidth(); if (!stylesMap.isEmpty()) { http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/6d9be145/android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java b/android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java index 749afbd..e9a5c79 100644 --- a/android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java +++ b/android/sdk/src/main/java/com/taobao/weex/dom/WXTextDomObject.java @@ -175,7 +175,7 @@ public class WXTextDomObject extends WXDomObject { spanned = createSpanned(mText); if(hasNewLayout()){ if(WXEnvironment.isApkDebugable()) { - WXLogUtils.w("TextDom", new IllegalStateException("Previous csslayout was ignored! markLayoutSeen() never called")); + WXLogUtils.d("Previous csslayout was ignored! markLayoutSeen() never called"); } markUpdateSeen(); } http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/6d9be145/android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java b/android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java index 79ba6e5..624c4c9 100755 --- a/android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java +++ b/android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java @@ -173,7 +173,7 @@ public class CSSNode { return; } else if (mLayoutState == LayoutState.HAS_NEW_LAYOUT) { if(WXEnvironment.isApkDebugable()){ - WXLogUtils.w("weex", new IllegalStateException("Previous csslayout was ignored! markLayoutSeen() never called")); + WXLogUtils.d("Previous csslayout was ignored! markLayoutSeen() never called"); } markLayoutSeen(); } http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/6d9be145/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java index 1d64d5d..d801290 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java @@ -337,7 +337,7 @@ public abstract class WXComponent<T extends View> implements IWXObject, IWXActi long startNanos = System.nanoTime(); if(!isLazy()) { if (component == null) { - component = this; + component = this; } setLayout(component.getDomObject()); setPadding(component.getDomObject().getPadding(), component.getDomObject().getBorder()); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/6d9be145/android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java index 1af8934..548a1a0 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java @@ -392,6 +392,7 @@ public class Statements { Map<String, Object> dynamic = dynamicLocal.get(); if(dynamic == null) { dynamic = new HashMap<>(); + dynamicLocal.set(dynamic); } if(dynamic.size() > 0){ dynamic.clear();