Repository: incubator-weex Updated Branches: refs/heads/master 8897646cc -> 8130b02ed
[WEEX-205][android] destroy instance should not be called when not rendered, Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/8130b02e Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/8130b02e Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/8130b02e Branch: refs/heads/master Commit: 8130b02ed3957a6920ed75724834af9cebc086b8 Parents: 9fac29c Author: jianbai.gbj <[email protected]> Authored: Wed Feb 7 14:37:03 2018 +0800 Committer: acton393 <[email protected]> Committed: Wed Feb 7 14:46:32 2018 +0800 ---------------------------------------------------------------------- android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/8130b02e/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---------------------------------------------------------------------- diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java index 9e452b5..475991e 100644 --- a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java +++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java @@ -1306,7 +1306,9 @@ public class WXSDKInstance implements IWXActivityStateListener,DomContext, View. public synchronized void destroy() { if(!isDestroy()) { - WXSDKManager.getInstance().destroyInstance(mInstanceId); + if(mRendered) { + WXSDKManager.getInstance().destroyInstance(mInstanceId); + } WXComponentFactory.removeComponentTypesByInstanceId(getInstanceId()); if (mGlobalEventReceiver != null) {
