[WEEX-442][Core] Use explicit
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/3dcab42c Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/3dcab42c Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/3dcab42c Branch: refs/heads/release Commit: 3dcab42c21d83136debbc77a6833a51641c1a4da Parents: e110f0a Author: miomin <[email protected]> Authored: Thu Jun 7 17:35:04 2018 +0800 Committer: YorkShen <[email protected]> Committed: Tue Jun 12 12:44:03 2018 +0800 ---------------------------------------------------------------------- weex_core/Source/core/render/action/render_action_add_element.h | 2 +- weex_core/Source/core/render/action/render_action_add_event.h | 2 +- .../core/render/action/render_action_appendtree_createfinish.h | 2 +- weex_core/Source/core/render/action/render_action_createbody.h | 2 +- weex_core/Source/core/render/action/render_action_createfinish.h | 2 +- weex_core/Source/core/render/action/render_action_layout.h | 2 +- weex_core/Source/core/render/action/render_action_move_element.h | 2 +- .../Source/core/render/action/render_action_remove_element.h | 2 +- weex_core/Source/core/render/action/render_action_remove_event.h | 2 +- weex_core/Source/core/render/action/render_action_update_attr.h | 2 +- weex_core/Source/core/render/action/render_action_update_style.h | 2 +- weex_core/Source/core/render/manager/render_manager.h | 2 +- weex_core/Source/core/render/node/factory/render_creator.h | 2 +- weex_core/Source/core/render/node/render_object.h | 2 +- weex_core/Source/core/render/page/render_page.h | 3 ++- 15 files changed, 16 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_add_element.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_add_element.h b/weex_core/Source/core/render/action/render_action_add_element.h index 25cc8ea..07968fc 100644 --- a/weex_core/Source/core/render/action/render_action_add_element.h +++ b/weex_core/Source/core/render/action/render_action_add_element.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionAddElement : public render_action { public: - RenderActionAddElement(const std::string &pageId, const RenderObject *render, const RenderObject *parent, + explicit RenderActionAddElement(const std::string &pageId, const RenderObject *render, const RenderObject *parent, int index, bool willLayout= true); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_add_event.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_add_event.h b/weex_core/Source/core/render/action/render_action_add_event.h index 12006d4..0de206b 100644 --- a/weex_core/Source/core/render/action/render_action_add_event.h +++ b/weex_core/Source/core/render/action/render_action_add_event.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionAddEvent : public render_action { public: - RenderActionAddEvent(const std::string &pageId, const std::string &ref, const std::string &event); + explicit RenderActionAddEvent(const std::string &pageId, const std::string &ref, const std::string &event); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_appendtree_createfinish.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_appendtree_createfinish.h b/weex_core/Source/core/render/action/render_action_appendtree_createfinish.h index 0f871e3..cdc968c 100644 --- a/weex_core/Source/core/render/action/render_action_appendtree_createfinish.h +++ b/weex_core/Source/core/render/action/render_action_appendtree_createfinish.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionAppendTreeCreateFinish : public render_action { public: - RenderActionAppendTreeCreateFinish(const std::string &pageId, const std::string &ref); + explicit RenderActionAppendTreeCreateFinish(const std::string &pageId, const std::string &ref); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_createbody.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_createbody.h b/weex_core/Source/core/render/action/render_action_createbody.h index 9655734..90b9827 100644 --- a/weex_core/Source/core/render/action/render_action_createbody.h +++ b/weex_core/Source/core/render/action/render_action_createbody.h @@ -25,7 +25,7 @@ namespace WeexCore { class RenderActionCreateBody : public render_action { public: - RenderActionCreateBody(const std::string &pageId, const RenderObject *render); + explicit RenderActionCreateBody(const std::string &pageId, const RenderObject *render); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_createfinish.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_createfinish.h b/weex_core/Source/core/render/action/render_action_createfinish.h index 19d5974..0b3407e 100644 --- a/weex_core/Source/core/render/action/render_action_createfinish.h +++ b/weex_core/Source/core/render/action/render_action_createfinish.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionCreateFinish : public render_action { public: - RenderActionCreateFinish(const std::string &pageId); + explicit RenderActionCreateFinish(const std::string &pageId); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_layout.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_layout.h b/weex_core/Source/core/render/action/render_action_layout.h index f9e1c90..868e476 100644 --- a/weex_core/Source/core/render/action/render_action_layout.h +++ b/weex_core/Source/core/render/action/render_action_layout.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionLayout : public render_action { public: - RenderActionLayout(const std::string &pageId, const RenderObject *render, const int index); + explicit RenderActionLayout(const std::string &pageId, const RenderObject *render, const int index); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_move_element.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_move_element.h b/weex_core/Source/core/render/action/render_action_move_element.h index aae2633..56db80b 100644 --- a/weex_core/Source/core/render/action/render_action_move_element.h +++ b/weex_core/Source/core/render/action/render_action_move_element.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionMoveElement : public render_action { public: - RenderActionMoveElement(const std::string &pageId, const std::string &ref, + explicit RenderActionMoveElement(const std::string &pageId, const std::string &ref, const std::string &parentRef, int index); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_remove_element.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_remove_element.h b/weex_core/Source/core/render/action/render_action_remove_element.h index 1e3ad59..d4342f1 100644 --- a/weex_core/Source/core/render/action/render_action_remove_element.h +++ b/weex_core/Source/core/render/action/render_action_remove_element.h @@ -25,7 +25,7 @@ namespace WeexCore { class RenderActionRemoveElement : public render_action { public: - RenderActionRemoveElement(const std::string &pageId, const std::string &ref); + explicit RenderActionRemoveElement(const std::string &pageId, const std::string &ref); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_remove_event.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_remove_event.h b/weex_core/Source/core/render/action/render_action_remove_event.h index 846f3c0..47ffe78 100644 --- a/weex_core/Source/core/render/action/render_action_remove_event.h +++ b/weex_core/Source/core/render/action/render_action_remove_event.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionRemoveEvent : public render_action { public: - RenderActionRemoveEvent(const std::string &pageId, const std::string &ref, const std::string &event); + explicit RenderActionRemoveEvent(const std::string &pageId, const std::string &ref, const std::string &event); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_update_attr.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_update_attr.h b/weex_core/Source/core/render/action/render_action_update_attr.h index 3131632..c9eeec1 100644 --- a/weex_core/Source/core/render/action/render_action_update_attr.h +++ b/weex_core/Source/core/render/action/render_action_update_attr.h @@ -26,7 +26,7 @@ namespace WeexCore { class RenderActionUpdateAttr : public render_action { public: - RenderActionUpdateAttr(const std::string &pageId, const std::string &ref, + explicit RenderActionUpdateAttr(const std::string &pageId, const std::string &ref, std::vector<std::pair<std::string, std::string>> *mAttrs); void ExecuteAction(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/action/render_action_update_style.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/action/render_action_update_style.h b/weex_core/Source/core/render/action/render_action_update_style.h index 85c73d2..e9d9f53 100644 --- a/weex_core/Source/core/render/action/render_action_update_style.h +++ b/weex_core/Source/core/render/action/render_action_update_style.h @@ -27,7 +27,7 @@ namespace WeexCore { public: - RenderActionUpdateStyle(const std::string &pageId, const std::string &ref, + explicit RenderActionUpdateStyle(const std::string &pageId, const std::string &ref, std::vector<std::pair<std::string, std::string>> *style, std::vector<std::pair<std::string, std::string>> *margin, std::vector<std::pair<std::string, std::string>> *padding, http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/manager/render_manager.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/manager/render_manager.h b/weex_core/Source/core/render/manager/render_manager.h index 78206e9..446001b 100644 --- a/weex_core/Source/core/render/manager/render_manager.h +++ b/weex_core/Source/core/render/manager/render_manager.h @@ -31,7 +31,7 @@ namespace WeexCore { class RenderManager { private: - RenderManager() {} + explicit RenderManager() {} ~RenderManager() {} http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/node/factory/render_creator.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/node/factory/render_creator.h b/weex_core/Source/core/render/node/factory/render_creator.h index a10b5f4..593eb57 100644 --- a/weex_core/Source/core/render/node/factory/render_creator.h +++ b/weex_core/Source/core/render/node/factory/render_creator.h @@ -28,7 +28,7 @@ namespace WeexCore { class RenderCreator { private: - RenderCreator() {} + explicit RenderCreator() {} ~RenderCreator() {} http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/node/render_object.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/node/render_object.h b/weex_core/Source/core/render/node/render_object.h index 758c3f1..062a4c3 100644 --- a/weex_core/Source/core/render/node/render_object.h +++ b/weex_core/Source/core/render/node/render_object.h @@ -136,7 +136,7 @@ namespace WeexCore { public: - RenderObject(); + explicit RenderObject(); ~RenderObject(); http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/3dcab42c/weex_core/Source/core/render/page/render_page.h ---------------------------------------------------------------------- diff --git a/weex_core/Source/core/render/page/render_page.h b/weex_core/Source/core/render/page/render_page.h index fce095f..369d057 100644 --- a/weex_core/Source/core/render/page/render_page.h +++ b/weex_core/Source/core/render/page/render_page.h @@ -74,7 +74,8 @@ namespace WeexCore { static constexpr bool useVSync = true; std::atomic_bool needLayout{false}; std::atomic_bool hasForeLayoutAction{false}; - RenderPage(std::string pageId); + + explicit RenderPage(std::string pageId); ~RenderPage();
