YorkShen closed pull request #2027: [core] fix event cant fire when event bingding on root node URL: https://github.com/apache/incubator-weex/pull/2027
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/weex_core/Source/core/data_render/vnode/vcomponent.h b/weex_core/Source/core/data_render/vnode/vcomponent.h index 704dd162e8..f142b30189 100644 --- a/weex_core/Source/core/data_render/vnode/vcomponent.h +++ b/weex_core/Source/core/data_render/vnode/vcomponent.h @@ -52,10 +52,7 @@ class VComponent : public VNode { void MoveTo(VComponent* new_component); inline const std::string render_object_ref() const override { - if (root_vnode_.get()) { - return root_vnode_->render_object_ref(); - } - return ""; + return "_component_" + std::to_string(id_); } inline int id() { return id_; } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services