wqyfavor closed pull request #2033: [ios] fixed layout.cpp crash in
scrollercomponent
URL: https://github.com/apache/incubator-weex/pull/2033
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
index 42f0ee2cb8..9fbcf35bd3 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
@@ -446,8 +446,7 @@ - (void)adjustForRTL
// this is scroll rtl solution.
// scroll layout not use direction, use self tranform
- if (self.view && _flexCssNode &&
_flexCssNode->getLayoutDirectionFromPathNode() == WeexCore::kDirectionRTL
- ) {
+ if (self.view && [self isDirectionRTL]) {
if (_transform) {
self.view.layer.transform =
CATransform3DConcat(self.view.layer.transform,
CATransform3DScale(CATransform3DIdentity, -1, 1, 1));
} else {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
