YorkShen commented on a change in pull request #2636: heron-merge
URL: https://github.com/apache/incubator-weex/pull/2636#discussion_r299379818
##########
File path: weex_core/Source/core/bridge/script/core_side_in_script.cpp
##########
@@ -71,18 +71,11 @@ std::unique_ptr<ValueWithType>
CoreSideInScript::CallNativeModule(
const char *page_id, const char *module, const char *method,
const char *arguments, int arguments_length, const char *options,
int options_length) {
- std::unique_ptr<ValueWithType> ret(new ValueWithType);
- ret->type = ParamsType::INT32;
- ret->value.int32Value = -1;
+ std::unique_ptr<ValueWithType> ret(new ValueWithType((int32_t)-1));
if (page_id != nullptr && module != nullptr && method != nullptr) {
- RenderManager::GetInstance()->CallNativeModule(page_id, module, method,
- arguments, arguments_length,
- options, options_length);
- return WeexCoreManager::Instance()
Review comment:
Add
return WeexCoreManager::Instance()
->getPlatformBridge()
->platform_side()
->CallNativeModule(page_id, module, method, arguments,
arguments_length,
options, options_length);
back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
