YorkShen commented on a change in pull request #2712: Update for libweexjsb path
URL: https://github.com/apache/incubator-weex/pull/2712#discussion_r303876311
##########
File path: android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
##########
@@ -145,15 +144,46 @@
private static String CORE_JSC_SO_PATH = null;
- private static String LIB_LD_PATH = null;
+ public static String CORE_JSB_SO_PATH = null;
+ private static String COPY_SO_DES_DIR = null;
+
+ private static String LIB_LD_PATH = null;
private static Map<String, String> options = new ConcurrentHashMap<>();
static {
options.put(WXConfig.os, OS);
options.put(WXConfig.osName, OS);
}
+
+ public static WXDefaultSettings getWXDefaultSettings() {
Review comment:
Make this method as `synchronized`, otherwise there may be two objects of
`mWXDefaultSettings` in multiple thread situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
