weex-bot commented on issue #2731: Add Lint in TravisCI and Update iOS TravisCI URL: https://github.com/apache/incubator-weex/pull/2731#issuecomment-513794532 <!-- 0 Errors 1 Warning: Code style violations detected... 0 Messages 3 Markdowns --> <table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true" data-kind="Warning"> 1 Warning </th> </tr> </thead> <tbody> <tr> <td>:warning:</td> <td data-sticky="false">Code style violations detected.</td> </tr> </tbody> </table> ### Code Style Check --- Code style violations detected in the following files: * `android/sdk/src/main/java/com/taobao/weex/adapter/ClassLoaderAdapter.java` * `android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java` * `ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h` * `ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m` * `ios/sdk/WeexSDK/Sources/Utility/WXVersion.m` Execute one of the following actions and commit again: 1. Run `clang-format` on the offending files 2. Apply the suggested patches with `git apply patch`. #### android/sdk/src/main/java/com/taobao/weex/adapter/ClassLoaderAdapter.java ```diff --- android/sdk/src/main/java/com/taobao/weex/adapter/ClassLoaderAdapter.java +++ android/sdk/src/main/java/com/taobao/weex/adapter/ClassLoaderAdapter.java @@ -53,4 +53,3 @@ } } - ``` #### android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java ```diff --- android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java +++ android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java @@ -291,7 +291,8 @@ } public static void copyJssRuntimeSo(){ - boolean tryUseRunTimeApi = WXUtils.checkGreyConfig("wxapm","use_runtime_api","0"); + boolean tryUseRunTimeApi = + WXUtils.checkGreyConfig("wxapm", "use_runtime_api", "0"); WXLogUtils.e("weex", "tryUseRunTimeApi ? "+ tryUseRunTimeApi); if (!tryUseRunTimeApi){ return; ``` #### ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h ```diff --- ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h +++ ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h @@ -25,4 +25,3 @@ @property (nonatomic,assign) BOOL ignoreInteraction; @end - ``` #### ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m ```diff --- ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m +++ ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m @@ -389,8 +389,9 @@ //some case , with out render (url) [self.apmInstance startRecord:self.instanceId]; self.apmInstance.isStartRender = YES; - - [_apmInstance setProperty:KEY_PAGE_PROPERTIES_UIKIT_TYPE withValue:_renderType?: WEEX_RENDER_TYPE_PLATFORM]; + + [_apmInstance setProperty:KEY_PAGE_PROPERTIES_UIKIT_TYPE + withValue:_renderType ?: WEEX_RENDER_TYPE_PLATFORM]; if (self.dataRender) { [self.apmInstance setProperty:KEY_PAGE_PROPERTIES_RENDER_TYPE withValue:@"eagle"]; } @@ -477,8 +478,9 @@ [self _checkPageName]; [self.apmInstance startRecord:self.instanceId]; self.apmInstance.isStartRender = YES; - - [_apmInstance setProperty:KEY_PAGE_PROPERTIES_UIKIT_TYPE withValue:_renderType?: WEEX_RENDER_TYPE_PLATFORM]; + + [_apmInstance setProperty:KEY_PAGE_PROPERTIES_UIKIT_TYPE + withValue:_renderType ?: WEEX_RENDER_TYPE_PLATFORM]; if (self.dataRender) { [self.apmInstance setProperty:KEY_PAGE_PROPERTIES_RENDER_TYPE withValue:@"eagle"]; } ``` #### ios/sdk/WeexSDK/Sources/Utility/WXVersion.m ```diff --- ios/sdk/WeexSDK/Sources/Utility/WXVersion.m +++ ios/sdk/WeexSDK/Sources/Utility/WXVersion.m @@ -20,7 +20,7 @@ #import "WXVersion.h" #import "WXDefine.h" -static const char* WeexSDKBuildTime = "2019-07-21 09:08:41 UTC"; +static const char *WeexSDKBuildTime = "2019-07-21 09:08:41 UTC"; static const unsigned long WeexSDKBuildTimestamp = 1563700121; NSString* GetWeexSDKVersion(void) ``` <p align="right" data-meta="generated_by_danger"> Generated by :no_entry_sign: <a href="https://danger.systems/";>Danger</a> </p>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
