YorkShen commented on a change in pull request #2731: Add Lint in TravisCI and
Update iOS TravisCI
URL: https://github.com/apache/incubator-weex/pull/2731#discussion_r307208765
##########
File path: dangerfile-ios.js
##########
@@ -90,22 +90,5 @@ if (!hasIosFile && danger.git.deleted_files) {
}
if(hasIosFile){
- console.log('hasIosFile');
-}
-//
console.log('-----------------------------hasIosFile-----------------------------:'+hasIosFile);
-// if(hasIosFile){
-// var runTestCmd='source ~/.bash_profile; '
-// +'xcodebuild -project ios/sdk/WeexSDK.xcodeproj test '
-// +'-scheme WeexSDKTests CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO '
-// +'-destination "platform=iOS Simulator,name=iPhone 6"'
-// runSuccess = shell.exec(runTestCmd,{ async: false, timeout: 8 * 60 *
1000, maxBuffer: 200 * 1024 * 1024 }).code == 0;
-// if(!runSuccess){
-// fail("ios platform run unit test failed!");
-// }
-// }else{
-// console.log('has no ios file changed.');
-// message('has no ios file changed.');
-// }
-// message('ios test finished.')
-
-
+ console.log('hasIosFile!!!');
Review comment:
You may need to consider rewriting the code with `if(hasIosFile)` block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
