weex-bot edited a comment on issue #2731: Add Lint in TravisCI and Update iOS TravisCI URL: https://github.com/apache/incubator-weex/pull/2731#issuecomment-516305383 <!-- 0 Errors 1 Warning: Code style violations detected... 0 Messages 3 Markdowns --> <table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true" data-kind="Warning"> 1 Warning </th> </tr> </thead> <tbody> <tr> <td>:warning:</td> <td data-sticky="false">Code style violations detected.</td> </tr> </tbody> </table> ### Code Style Check --- Code style violations detected in the following files: * `android/sdk/src/main/java/com/taobao/weex/ComponentObserver.java` * `ios/sdk/WeexSDK/Sources/Utility/WXVersion.m` If you have not install `clang-format`, you can install clang-format by `npm install -g clang-format` Then Execute one of the following actions and commit again: 1. Run `clang-format -i ` on the offending files 2. Apply the suggested patches with `git apply patch`. If you use Xcode,you can also use clang-format plugin: https://github.com/travisjeffery/ClangFormat-Xcode #### android/sdk/src/main/java/com/taobao/weex/ComponentObserver.java ```diff --- android/sdk/src/main/java/com/taobao/weex/ComponentObserver.java +++ android/sdk/src/main/java/com/taobao/weex/ComponentObserver.java @@ -48,4 +48,3 @@ */ void onViewCreated(WXComponent component,View view); } - ``` #### ios/sdk/WeexSDK/Sources/Utility/WXVersion.m ```diff --- ios/sdk/WeexSDK/Sources/Utility/WXVersion.m +++ ios/sdk/WeexSDK/Sources/Utility/WXVersion.m @@ -20,7 +20,7 @@ #import "WXVersion.h" #import "WXDefine.h" -static const char* WeexSDKBuildTime = "2019-07-21 09:08:41 UTC"; +static const char *WeexSDKBuildTime = "2019-07-21 09:08:41 UTC"; static const unsigned long WeexSDKBuildTimestamp = 1563700121; NSString* GetWeexSDKVersion(void) ``` <p align="right" data-meta="generated_by_codeFormat"> Generated by :no_entry_sign: <a href="https://danger.systems/";>Danger</a> </p>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
