weex-bot edited a comment on issue #2731: Add Lint in TravisCI and Update iOS TravisCI URL: https://github.com/apache/incubator-weex/pull/2731#issuecomment-516670450 <!-- 0 failure: 2 warning: OCLint Result, Summary: TotalFil... DangerID: danger-id-oclint; --> <table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>OCLint Result</td> </tr> <tr> <td>:warning:</td> <td> Summary: TotalFiles=370 FilesWithViolations=112 P1=0 P2=68 P3=965 /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/RecycleList/WXRecycleListTemplateManager.m:86:49: dead code [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm:269:12: empty else block [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm:938:36: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Manager/WXServiceFactory.m:44:28: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m:433:53: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/third_party/json11/json11.cc:149:1: destructor of virtual class [convention|P2] class Value should have a virtual destructor ~Value() /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm:1103:51: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:8: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:32: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:57: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:84: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:39:50: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:39:77: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m:37:15: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTransform.m:180:56: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXSliderNeighborComponent.mm:1624:5: empty do/while statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXSliderNeighborComponent.mm:96:16: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m:298:17: empty do/while statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m:84:34: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:249:58: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:250:50: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:251:62: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:252:59: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:253:50: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:254:63: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:255:74: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:256:62: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:257:54: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:258:60: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:259:54: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Module/WXStreamModule.m:293:13: dead code [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m:706:29: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m:993:16: empty else block [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/RecycleList/WXComponent+DataBinding.mm:201:52: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m:1064:37: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/core/render/manager/render_manager.cpp:457:45: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm:678:145: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Module/WXStorageModule.m:463:5: empty do/while statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.mm:733:53: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.mm:735:57: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.mm:756:57: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:979:33: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:997:33: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:1019:38: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:1041:35: empty catch statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:403:28: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm:659:27: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:913:41: dead code [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:409:20: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:492:15: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:555:19: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:715:19: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m:111:15: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:167:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:399:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:1041:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/wson/wson_parser.cpp:234:13: dead code [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/wson/wson_parser.cpp:154:5: missing break in switch statement [convention|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXCycleSliderComponent.mm:649:5: empty do/while statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Module/WXModalUIModule.m:83:30: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:394:14: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:394:35: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:521:25: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:839:20: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXConvert.m:138:16: empty else block [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/Recycler/WXMultiColumnLayout.m:193:20: empty finally statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/RecycleList/WXJSASTParser.mm:878:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/RecycleList/WXJSASTParser.mm:290:5: missing break in switch statement [convention|P2] </td> </tr> </tbody> </table> <p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js";>dangerJS</a> against 6f628291822d5f52055238af149c23d5eeb550fd </p>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
