YorkShen commented on a change in pull request #2731: Add Lint in TravisCI and Update iOS TravisCI URL: https://github.com/apache/incubator-weex/pull/2731#discussion_r310020964
########## File path: Dangerfile ########## @@ -0,0 +1 @@ +code_style_validation.check file_extensions: ['.cc', '.cpp', '.m', 'mm', '.h', '.java'] Review comment: Correct me if I am wrong. It seems like you are using the ruby version of danger for `code_format`, and the ruby version danger will some use `Dangerfile` as its source. If this is the case, relying on `https://github.com/wrmswindmill/danger-code_style_validation.git` is not an option in my knowledge, as the source file could be changed in any minutes. At least, you should rely a publish version of `https://github.com/wrmswindmill/danger-code_style_validation.git`. I suggest you share your ideas in the mailing list. PS: 1. I don't see the output of the code format in danger. 1. You should also provide a format script or file, within which developers could import the file into their IDE( `XCode` or `Android Studio`) and format code with one click. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
