weex-bot commented on issue #2778: [iOS]Fix some oclint warning URL: https://github.com/apache/incubator-weex/pull/2778#issuecomment-519411299 <!-- 2 failure: OCLint Result, Summary: TotalFil... 0 warning: DangerID: danger-id-oclint; --> <table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Fails</th> </tr> </thead> <tbody><tr> <td>:no_entry_sign:</td> <td>OCLint Result</td> </tr> <tr> <td>:no_entry_sign:</td> <td> Summary: TotalFiles=370 FilesWithViolations=112 P1=0 P2=28 P3=968 /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m:433:53: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/third_party/json11/json11.cc:149:1: destructor of virtual class [convention|P2] class Value should have a virtual destructor ~Value() /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:8: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:32: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:57: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:36:84: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:39:50: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Display/UIBezierPath+Weex.m:39:77: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTransform.m:180:56: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:249:58: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:250:50: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:251:62: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:252:59: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:253:50: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:254:63: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:255:74: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:256:62: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:257:54: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:258:60: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Component/WXTextComponent.mm:259:54: constant if expression [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/core/render/manager/render_manager.cpp:457:45: empty if statement [empty|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:167:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:399:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm:1041:9: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/weex_core/Source/wson/wson_parser.cpp:154:5: missing break in switch statement [convention|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:394:14: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:394:35: constant conditional operator [basic|P2] /Users/travis/build/apache/incubator-weex/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m:521:25: constant conditional operator [basic|P2] </td> </tr> </tbody> </table> <p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js";>dangerJS</a> against 6e2a51eef82dd6a8509e378519a64a65697c2972 </p>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
