[GitHub] [incubator-weex] YorkShen opened a new pull request #2902: [Android] Fix Crash in NotifyLayout

[GitBox]

YorkShen opened a new pull request #2902: [Android] Fix Crash in NotifyLayout
URL: https://github.com/apache/incubator-weex/pull/2902
 
 
   There is a concurrent read/write operation to `RenderManager::pages_` during 
`CoreSideInPlatform::NotifyLayout`where MainThread is reading 
`RenderManager::pages_` while other thread may be writing to it.
   
   ```
   std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> >::__is_long() const at string:1266
    (inlined by) std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >::size() const at 
string:905
    (inlined by) std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> 
>::compare(std::__ndk1::basic_string_view<char, std::__ndk1::char_traits<char> 
>) const at string:3455
    (inlined by) std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> 
>::compare(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> > const&) const at string:3473
    (inlined by) bool std::__ndk1::operator< <char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> 
>(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> > const&, std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) at 
string:3693
    (inlined by) std::__ndk1::less<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > 
>::operator()(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> > const&, std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) const at 
__functional_base:55
    (inlined by) 
std::__ndk1::__map_value_compare<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, std::__ndk1::less<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, 
true>::operator()(std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*> const&, std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) const at 
map:476
    (inlined by) 
std::__ndk1::__tree_iterator<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, 
std::__ndk1::__tree_node<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, void*>*, int> 
std::__ndk1::__tree<std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, 
std::__ndk1::__map_value_compare<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, std::__ndk1::less<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, true>, 
std::__ndk1::allocator<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*> > >::__lower_bound<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > 
>(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> > const&, 
std::__ndk1::__tree_node<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, void*>*, 
std::__ndk1::__tree_end_node<std::__ndk1::__tree_node_base<void*>*>*) at 
__tree:2476
   
std::__ndk1::__tree_iterator<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, 
std::__ndk1::__tree_node<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, void*>*, int> 
std::__ndk1::__tree<std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, 
std::__ndk1::__map_value_compare<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
std::__ndk1::__value_type<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*>, std::__ndk1::less<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, true>, 
std::__ndk1::allocator<std::__ndk1::__value_type<std::__ndk1::basic_string<char,
 std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*> > >::find<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > 
>(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, 
std::__ndk1::allocator<char> > const&) at __tree:2405
   std::__ndk1::map<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, 
WeexCore::RenderPageBase*, std::__ndk1::less<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, 
std::__ndk1::allocator<std::__ndk1::pair<std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const, 
WeexCore::RenderPageBase*> > >::find(std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) at 
map:1262
    (inlined by) 
WeexCore::RenderManager::GetPage(std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) at 
render_manager.cpp:472
   WeexCore::CoreSideInPlatform::NotifyLayout(std::__ndk1::basic_string<char, 
std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) at 
core_side_in_platform.cpp:223
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services