weex-bot edited a comment on issue #2940: * [Android] Remove shared library 
from binary of Weex
URL: https://github.com/apache/incubator-weex/pull/2940#issuecomment-535382899
 
 
   
   <!--
     0 failure: 
     5 warning:  Potential BREAK C..., No Changelog chan..., Current pr not 
bi..., If your PR is abo..., If you update the...
     
     
     DangerID: danger-id-danger;
   -->
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it 
in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do 
so,append your changes to the changelog.md</i></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you 
should add the demo link in the PR description. Demo link: <a 
href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If you update the code, maybe you should update the documentation 
and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: <a 
href='https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document'>https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document</a></td>
       </tr>
     </tbody>
   </table>
   
   
   
   <p align="right">
     Generated by :no_entry_sign: <a 
href="https://danger.systems/js";>dangerJS</a> against 
89ec540930e64d6e0ec9655cb1b68c7f347b7d14
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to