weex-bot edited a comment on issue #2958: [Android] support switch javascriptCore (legacy)or jsc (apache) URL: https://github.com/apache/incubator-weex/pull/2958#issuecomment-540931797 <!-- 0 failure: 5 warning: Potential BREAK C..., No Changelog chan..., Current pr not bi..., If your PR is abo..., You'd better to s... DangerID: danger-id-danger; --> <table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td> </tr> <tr> <td>:warning:</td> <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td> </tr> <tr> <td>:warning:</td> <td>Current pr not bind the milestone</td> </tr> <tr> <td>:warning:</td> <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td> </tr> <tr> <td>:warning:</td> <td>You'd better to submit PR to master branch as the development of Weex is on master branch.</td> </tr> </tbody> </table> <p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js";>dangerJS</a> against ca534d5b63a104207617372d9ca71de065db4578 </p>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
