YorkShen commented on a change in pull request #3167: Feature(Android): Support
x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392580465
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q
"hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true
${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI}
-PbuildRuntimeApi=false
-Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar";
-Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore"
-PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true
${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI}
-PbuildRuntimeApi=false
-Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar";
-Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore"
-PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI}
-PbuildRuntimeApi=false
-Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar";
-Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore"
-PapachePackageName="false" || exit 1
Review comment:
`JavaScriptCore.so` is still working now, but no body is maintaining it. As
time goes and things happen(like it doesn't support x86_64), it will be
abondoned eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
