Commit 2e6ee833436323f7ee587929074eac1f074f4fcd:
Fix crash with https://whimsy.apache.org/roster/committer/tpappas
Branch: refs/heads/master
Author: Sebb <[email protected]>
Committer: Sebb <[email protected]>
Pusher: sebb <[email protected]>
------------------------------------------------------------
www/roster/models/committer.rb | +++++++ -----
------------------------------------------------------------
12 changes: 7 additions, 5 deletions.
------------------------------------------------------------
diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb
index 4283a88..0ffe1a9 100644
--- a/www/roster/models/committer.rb
+++ b/www/roster/models/committer.rb
@@ -73,11 +73,13 @@ def self.serialize(id, env)
if ASF::Person.find(env.user).asf_member?
response[:forms] = {}
- iclas = ASF::SVN['private/documents/iclas']
- if File.exist? File.join(iclas, person.icla.claRef + '.pdf')
- response[:forms][:icla] = person.icla.claRef + '.pdf'
- elsif Dir.exist? File.join(iclas, person.icla.claRef)
- response[:forms][:icla] = person.icla.claRef + '/'
+ if person.icla.claRef # Not all people in members unix group have iclas
+ iclas = ASF::SVN['private/documents/iclas']
+ if File.exist? File.join(iclas, person.icla.claRef + '.pdf')
+ response[:forms][:icla] = person.icla.claRef + '.pdf'
+ elsif Dir.exist? File.join(iclas, person.icla.claRef)
+ response[:forms][:icla] = person.icla.claRef + '/'
+ end
end
member = {}
