This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b3415c  Flag up missing pmc-chairs membership
6b3415c is described below

commit 6b3415cbeb967541537970636a76b4782d753cca
Author: Sebb <s...@apache.org>
AuthorDate: Fri Mar 2 22:50:15 2018 +0000

    Flag up missing pmc-chairs membership
---
 www/roster/models/committee.rb | 6 ++++++
 www/roster/views/pmc/pmc.js.rb | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/roster/models/committee.rb b/www/roster/models/committee.rb
index 07b821a..bfa1af7 100644
--- a/www/roster/models/committee.rb
+++ b/www/roster/models/committee.rb
@@ -107,9 +107,15 @@ class Committee
       }
     end
 
+    pmc_chair = false
+    if pmc.chair
+      pmcchairs = ASF::Service.find('pmc-chairs')
+      pmc_chair = pmcchairs.members.include? pmc.chair
+    end
     response = {
       id: id,
       chair: pmc.chair && pmc.chair.id,
+      pmc_chair: pmc_chair,
       display_name: pmc.display_name,
       description: pmc.description,
       schedule: pmc.schedule,
diff --git a/www/roster/views/pmc/pmc.js.rb b/www/roster/views/pmc/pmc.js.rb
index 63744e6..1e7477f 100644
--- a/www/roster/views/pmc/pmc.js.rb
+++ b/www/roster/views/pmc/pmc.js.rb
@@ -215,7 +215,7 @@ class PMCMember < Vue
       elsif not @@committee.committers.include? @@person.id
         _td.issue.clickable 'not in committer list', onClick: self.select
       elsif @@person.id == @@committee.chair
-        _td.chair.clickable 'chair', onClick: self.select
+        _td.chair.clickable (@@committee.pmc_chair ? 'chair' : 'chair (not in 
pmc-chairs)'), onClick: self.select
       else
         _td.clickable '', onClick: self.select
       end

-- 
To stop receiving notification emails like this one, please contact
s...@apache.org.

Reply via email to