This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new dfa35b5  Show if person has ICLA to all
dfa35b5 is described below

commit dfa35b56fdca170d6c12180c28603e4069e63f65
Author: Sebb <[email protected]>
AuthorDate: Thu May 10 21:51:32 2018 +0100

    Show if person has ICLA to all
---
 www/roster/models/committer.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb
index aeced1a..3ea714a 100644
--- a/www/roster/models/committer.rb
+++ b/www/roster/models/committer.rb
@@ -108,8 +108,9 @@ class Committer
       member[:status] = ASF::Member.status[id] || 'Active'
     end
 
+    response[:forms] = {}
+
     if ASF::Person.find(env.user).asf_member? # i.e. member karma
-      response[:forms] = {}
 
       if person.icla and person.icla.claRef # Not all people have iclas
         iclas = ASF::SVN['iclas']
@@ -146,6 +147,8 @@ class Committer
         end
       end
 
+    else # not an ASF member; no karma for ICLA docs so don't add link
+      response[:forms][:icla] = '' if person.icla and person.icla.claRef
     end
 
     response[:member] = member unless member.empty?

-- 
To stop receiving notification emails like this one, please contact
[email protected].

Reply via email to