This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 1adb7fc  More docs
1adb7fc is described below

commit 1adb7fc264478ec1192d31bc1fef3add087c4c23
Author: Sebb <[email protected]>
AuthorDate: Sat Feb 9 16:18:22 2019 +0000

    More docs
---
 lib/whimsy/asf/ldap.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index c4dc6c8..5abb14d 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1236,12 +1236,15 @@ module ASF
     @base = 'ou=pmc,ou=committees,ou=groups,dc=apache,dc=org'
 
     # return a list of committees, from LDAP.
+    # TODO this stopped returning all PMCs when guinea pigs were introduced
+    # Should it be dropped, or made to return the list of PMCs ?
     def self.list(filter='cn=*')
       ASF.search_one(base, filter, 'cn').flatten.map {|cn| Committee.find(cn)}
     end
 
     # fetch <tt>dn</tt>, <tt>member</tt>, <tt>modifyTimestamp</tt>, and
     # <tt>createTimestamp</tt> for all committees in LDAP.
+    # TODO - delete? Not sure it's used anymore
     def self.preload
       Hash[ASF.search_one(base, "cn=*", %w(dn member modifyTimestamp 
createTimestamp)).map do |results|
         cn = results['dn'].first[/^cn=(.*?),/, 1]

Reply via email to