[whimsy] branch master updated: List the duplicate stem errors together

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new cc08110  List the duplicate stem errors together
cc08110 is described below

commit cc081103929dae04bcba4c4c5728bb792a53d662
Author: Sebb <s...@apache.org>
AuthorDate: Thu Jul 25 23:20:26 2019 +0100

    List the duplicate stem errors together
---
 www/secretary/icla-lint.cgi | 44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/www/secretary/icla-lint.cgi b/www/secretary/icla-lint.cgi
index 1c02249..aa48ec4 100755
--- a/www/secretary/icla-lint.cgi
+++ b/www/secretary/icla-lint.cgi
@@ -79,28 +79,6 @@ _html do
     iclas[stem] << name
   end
 
-  if dupes > 0
-    _h2_ 'Files with duplicate stems'
-    _table_ do
-      _tr do
-        _th 'stem'
-        _th 'paths'
-      end
-      iclas.each do |icla,paths|
-        if paths.size > 1
-          _tr do
-            _td icla
-            _td do
-              paths.each do |path|
-                _a path, href: 
"https://svn.apache.org/repos/private/documents/iclas/#{path}";
-              end
-            end
-          end
-        end
-      end      
-    end
-  end
-
   seen=Hash.new(0) # iclas.txt CLA stem values
   icla_ids=Hash.new{ |h,k| h[k] = []} # to check for duplicates and missing 
entries
   icla_mails=Hash.new{ |h,k| h[k] = []} # to check for duplicates
@@ -220,6 +198,28 @@ _html do
     _ 'All committers have ICLAs'
   end
 
+  if dupes > 0
+    _h2_ 'Files with duplicate stems'
+    _table_ do
+      _tr do
+        _th 'stem'
+        _th 'paths'
+      end
+      iclas.each do |icla,paths|
+        if paths.size > 1
+          _tr do
+            _td icla
+            _td do
+              paths.each do |path|
+                _a path, href: 
"https://svn.apache.org/repos/private/documents/iclas/#{path}";
+              end
+            end
+          end
+        end
+      end      
+    end
+  end
+
   # drop any stems we have seen
   iclas.reject! {|path| seen.include? path}